From 2c4711231d863981a28ea0a69d44af76e5125cf3 Mon Sep 17 00:00:00 2001 From: Osamu Takiya Date: Thu, 23 Jun 2022 17:32:03 +0900 Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9B=20=E6=8A=95=E7=A5=A8?= =?UTF-8?q?=E3=83=81=E3=82=A7=E3=83=83=E3=82=AF=E3=81=AB=E3=81=A6=E3=82=B9?= =?UTF-8?q?=E3=82=AF=E3=83=AA=E3=83=BC=E3=83=B3=E3=83=8D=E3=83=BC=E3=83=A0?= =?UTF-8?q?=E3=81=8C=E8=A6=8B=E3=81=A4=E3=81=8B=E3=82=89=E3=81=AA=E3=81=84?= =?UTF-8?q?=E3=81=A8=E3=81=8D=E3=81=AB=E9=81=A9=E5=88=87=E3=81=AA=E3=83=AC?= =?UTF-8?q?=E3=82=B9=E3=83=9D=E3=83=B3=E3=82=B9=E3=82=92=E8=BF=94=E3=81=99?= =?UTF-8?q?=E3=82=88=E3=81=86=E3=81=AB=E4=BF=AE=E6=AD=A3=20(#144)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app/controllers/check_votes_and_bonuses_controller.rb | 10 ++++++++-- .../check_votes_and_bonuses_controller_spec.rb | 10 +++++++++- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/app/controllers/check_votes_and_bonuses_controller.rb b/app/controllers/check_votes_and_bonuses_controller.rb index 70318d3d..cc640c47 100644 --- a/app/controllers/check_votes_and_bonuses_controller.rb +++ b/app/controllers/check_votes_and_bonuses_controller.rb @@ -3,8 +3,14 @@ def index screen_name = Presenter::Common.normalized_screen_name(params[:screen_name]) user = User.find_by(screen_name: screen_name) - # TODO: エラーハンドリング - return render json: {} if user.blank? + error_response = { + gss2022: [], + unite_attacks: [], + short_stories: [], + fav_quotes: [], + sosenkyo_campaigns: [] + } + return render json: error_response if user.blank? gss2022_tweets = user.tweets.gensosenkyo_2022_votes_for_api unite_attacks_tweets = user.tweets.unite_attacks_votes_for_api diff --git a/spec/requests/check_votes_and_bonuses_controller_spec.rb b/spec/requests/check_votes_and_bonuses_controller_spec.rb index 7540d0a7..0f524b55 100644 --- a/spec/requests/check_votes_and_bonuses_controller_spec.rb +++ b/spec/requests/check_votes_and_bonuses_controller_spec.rb @@ -7,7 +7,15 @@ get check_votes_and_bonuses_path(screen_name: '@test_user') expect(response).to have_http_status :ok - expect(response.body).to eq '{}' + expect(JSON.parse(response.body)).to eq( + { + "gss2022" => [], + "unite_attacks" => [], + "short_stories" => [], + "fav_quotes" => [], + "sosenkyo_campaigns" => [] + } + ) end it 'データベースに存在するとき、期待通りのレスポンスが返ってくること' do