Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omgrpc does not support grpc validation rules #33

Open
nickman opened this issue Feb 21, 2018 · 1 comment
Open

omgrpc does not support grpc validation rules #33

nickman opened this issue Feb 21, 2018 · 1 comment

Comments

@nickman
Copy link

nickman commented Feb 21, 2018

Trying to import an envoy proto. omgrpc reports:

Uh oh, something went wrong when importing that proto file... check the console and email me about it: Error: Parse error at line 39: illegal option name: (validate.rules).double.,

The issue is that it's choking on the validation syntax. Offending line looks like this:

// Identifies a percentage, in the range [0.0, 100.0].
message Percent {
  double value = 1 [(validate.rules).double = {gte: 0, lte: 100}];
}

@troylelandshields
Copy link
Owner

Dang... We need to update the grpc dependency, hopefully that will fix it. Thanks for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants