Merge pull request #59 from trolley/repo-update

fix, feat: Repo update, tests update

Author: Aman Aalam

composer.json

@@ -2,7 +2,7 @@
     "name": "trolley/core",
     "type": "library",
     "description": "Trolley PHP SDK",
-    "homepage": "https://github.com/PaymentRails/php-sdk",
+    "homepage": "https://github.com/Trolley/php-sdk",
     "keywords": [
         "PaymentRails",
         "Trolley"

lib/Trolley/Batch.php

@@ -68,13 +68,13 @@ public static function find($batchId)
     /**
      * Create a batch
      *
-     * @param mixed $params
+     * @param mixed $batchDescription
      * @param mixed $payments
      * @return Batch
      */
-    public static function create($params, $payments = null)
+    public static function create($batchDescription, $payments = null)
     {
-        return Configuration::gateway()->batch()->create($params, $payments);
+        return Configuration::gateway()->batch()->create($batchDescription, $payments);
     }
 
     /**

lib/Trolley/Version.php

@@ -12,7 +12,7 @@ class Version
      */
     const MAJOR = 3;
     const MINOR = 0;
-    const TINY = 0;
+    const TINY = 1;
 
     /**
      * @ignore

tests/integration/BatchTest.php

@@ -43,7 +43,7 @@ private function deleteRecipient($recipientId) {
         $this->assertTrue($response);
     }
 
-    /* public function testErrors(){
+    public function testErrors(){
 
         //create inactive Recipient to send payment to
         $recipient = $this->createRecipient();
@@ -78,6 +78,23 @@ public function testAll_smokeTest()
     {
         $all = Trolley\Batch::all();
         $this->assertTrue($all->maximumCount() > 0);
+
+        $batch = Trolley\Batch::create([
+            "sourceCurrency" => "USD",
+            "description"    => "Integration Test Create : PHP SDK",
+            "tags"           => ["PHPSDK"]
+        ]);
+
+        $searchResult = Trolley\Batch::search([
+            "search"    => "PHPSDK",
+            "page"      => 1,
+            "pageSize"  => 5
+        ]);
+
+        $this->assertEquals($searchResult->firstItem()->id, $batch->id);
+        
+        $response = Trolley\Batch::delete($batch->id);
+        $this->assertTrue($response);
     }
 
     public function testBalances(){
@@ -151,7 +168,7 @@ public function testUpdate() {
         $response = Trolley\Batch::delete($batch->id);
 
         $this->assertTrue($response);
-    }  */
+    } 
 
     public function testCreateWithPayments()
     {
@@ -194,7 +211,7 @@ public function testCreateWithPayments()
         $this->deleteRecipient($recipientBeta->id);
     }
 
-    /* public function testPayments()
+    public function testPayments()
     {
         $batch = Trolley\Batch::create([
             "sourceCurrency" => "USD",
@@ -220,6 +237,9 @@ public function testCreateWithPayments()
 
         $this->assertTrue($response);
 
+        $response = Trolley\Batch::findPayment($batch->id, $payment->id);
+        $this->assertEquals($response->id, $payment->id);
+
         $response = Trolley\Batch::deletePayment($batch->id, $payment->id);
 
         $this->assertTrue($response);
@@ -273,5 +293,5 @@ public function testProcessing()
 
         $this->deleteRecipient($recipientAlpha->id);
         $this->deleteRecipient($recipientBeta->id);
-    } */
+    }
 }

tests/integration/RecipientTest.php

@@ -80,6 +80,15 @@ public function testLifecycle()
         $fetchResult = Trolley\Recipient::find($createResult->id);
         $this->assertEquals('Bob', $fetchResult->firstName);
 
+        $searchResult = Trolley\Recipient::search(
+            [
+                "name"      =>  $createResult->firstName,
+                "page"      =>  1,
+                "pageSize"  =>  2
+            ]
+        );
+        $this->assertEquals($searchResult->firstItem()->firstName, $createResult->firstName);
+
         $deleteResult = Trolley\Recipient::delete($createResult->id);
         $this->assertTrue($deleteResult);