Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling infinite scroll with reapeted numbers #34

Closed
Noam-m33 opened this issue Jul 29, 2024 · 1 comment
Closed

disabling infinite scroll with reapeted numbers #34

Noam-m33 opened this issue Jul 29, 2024 · 1 comment

Comments

@Noam-m33
Copy link

Noam-m33 commented Jul 29, 2024

Hi,

The disabling infinite scroll props works fine but we still had the number who is repeated 3 times.

Enregistrement.de.l.ecran.2024-07-29.a.14.06.31.mov

It's look's like we can easily fix it with this line
[Edit: the initialScrollIndex not working with this change]
Capture d’écran 2024-07-29 à 14 08 40

In case it's not a bug and the appropriate behavior of the disable infinite scroll feature it could be great to adding a props to personalize the repeatNTimes.

Thanks for your work !

@troberts-28
Copy link
Owner

Hey @Noam-m33!

Thank you for raising this. This isn't actually a bug, but you should absolutely be able to configure the number of times the hours are repeated. I have added three props to allow you to do so for each picker: repeatHourNumbersNTimes, repeatMinuteNumbersNTimes and repeatSecondNumbersNTimes. They are set to 6, 3 and 3, respectively, to give a user the feeling of an endless loop (even when disableInfiniteScroll is set to true). You can set all of these to 1 to avoid any looping at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants