Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Request: Add possibility to configure padNumbersWithZero #31

Closed
pkovaacs opened this issue Jul 2, 2024 · 3 comments
Closed

Comments

@pkovaacs
Copy link

pkovaacs commented Jul 2, 2024

In case of minutes and seconds, single digits are padded with zero by default. But currently there is no option for hours to be padded with zero.
Please make it configurable by giving some control to TimerPicker for padNumbersWithZero prop of each DurationScroll, instead of the current setup with hardcoded boolean values.
Thank you in advance.

@troberts-28
Copy link
Owner

Hey @kocelke1,

Thank you for the great suggestion! Will add this to the library in the coming weeks, or feel free to submit a PR if you'd like it added sooner 🚀

@pkovaacs
Copy link
Author

pkovaacs commented Jul 2, 2024

Thank you for your response, no rush needed.

@troberts-28
Copy link
Owner

Hey @kocelke1, all done 🙌

Upgrade to v1.10.1 to use the new props:

  • padHoursWithZero
  • padMinutesWithZero
  • padSecondsWithZero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants