Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatTime missing from examples #28

Closed
callum-gander opened this issue Jun 7, 2024 · 2 comments
Closed

formatTime missing from examples #28

callum-gander opened this issue Jun 7, 2024 · 2 comments

Comments

@callum-gander
Copy link

Hi,

In the examples you give, there's a formatTime function being called, but this is never imported or defined. Could this be clarified in the examples? Either by importing it or defining what this formatTime is expected to look like, obviously I'm guessing it will vary and be dictated by the user but having an example within the example would improve the quality of the docs.

Thanks, great package btw

@troberts-28
Copy link
Owner

Hey @callum-gander 👋

This is a great shout. You're right that the formatTime function is just a utility function to display the selected time, but it would absolutely make the examples more complete if it were included. Will add it in 🙌

@callum-gander
Copy link
Author

Perfect! Thanks for the quick response 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants