Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support type stability for Float32 when calling rhs! #12

Closed
huiyuxie opened this issue May 13, 2024 · 2 comments
Closed

Support type stability for Float32 when calling rhs! #12

huiyuxie opened this issue May 13, 2024 · 2 comments
Assignees
@huiyuxie
Labels
upstream Related to upstream

Comments

@huiyuxie
Copy link
Collaborator

huiyuxie commented May 13, 2024 •
edited
Loading

GPU support requires type stability of Float32 to achieve better performance. But Trixi.jl lacks type stability for Float32, and it causes errors in some GPU kernels during compilation. It's good to address type stability in PDE equations and their related flux functions first.

Related Issue:
trixi-framework/Trixi.jl#591

Related PRs:
trixi-framework/Trixi.jl#1938 (docs)
trixi-framework/Trixi.jl#1948 (helper)
trixi-framework/Trixi.jl#1909 (main)
@huiyuxie huiyuxie added the enhancement New feature or request label May 13, 2024
@huiyuxie huiyuxie self-assigned this May 13, 2024
@huiyuxie huiyuxie added good first issue Good for newcomers and removed good first issue Good for newcomers labels May 13, 2024
@huiyuxie
Copy link
Collaborator Author

Close as completed.

@huiyuxie huiyuxie changed the title Enhance support of type stability for upstream repository Support type stability for Float32 when calling rhs! Aug 20, 2024
@huiyuxie huiyuxie added upstream Related to upstream and removed enhancement New feature or request labels Aug 20, 2024
@huiyuxie
Copy link
Collaborator Author

Please note that the helper PR is still in discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huiyuxie huiyuxie

Labels
upstream Related to upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huiyuxie