-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RealT
conversion from SVector
#2099
base: main
Are you sure you want to change the base?
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2099 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 470 470
Lines 37497 37503 +6
=======================================
+ Hits 36125 36131 +6
Misses 1372 1372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
If there is a reasonable way to avoid |
I cannot understand why we have to avoid |
Please do not merge - I don't think it is a good way. |
The inner type conversion is too dynamic for GPU kernels and it caused errors in my place during kernel compilation. But if the type conversion is removed, the kernel compilation looks good.
But it will bring some
Float64
computation - do you @ranocha think it is Ok?