Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test in docs/.../differentiable_programming.jl sometimes fails #1703

Closed
ArseniyKholod opened this issue Nov 3, 2023 · 5 comments · Fixed by #1704
Closed

Test in docs/.../differentiable_programming.jl sometimes fails #1703

ArseniyKholod opened this issue Nov 3, 2023 · 5 comments · Fixed by #1704
Labels
bug Something isn't working

Comments

@ArseniyKholod
Copy link
Contributor

ArseniyKholod commented Nov 3, 2023

I noticed that sometimes Documentation CI fails due to the error in test inside docs/literate/src/files/differentiable_programming.jl.
Four recent failures in four different PRs
https://github.com/trixi-framework/Trixi.jl/actions/runs/6745400585
https://github.com/trixi-framework/Trixi.jl/actions/runs/6747174166
https://github.com/trixi-framework/Trixi.jl/actions/runs/6743238156/job/18330780159
https://github.com/trixi-framework/Trixi.jl/actions/runs/6747950967

Failures happen in the following lines
@test 3.0e-10 < relative_maximum < 8.0e-10 #src
and
@test 1.0e-17 < relative_maximum < 1.0e-15 #src
All failures that I saw have the same calculated values causing problems.
3.0e-10 < 8.869894585050838e-10 < 8.0e-10
1.0e-17 < 1.170548031529666e-15 < 1.0e-15
Local on Windows tests are always passed.

Different seems to be quite small, does make sense to expand acceptable values?

@JoshuaLampert
Copy link
Member

Looks like the error is related to other CI failures we recently have in various PRs. I think, we should investigate this further instead of just adapting the tolerances. Locally, I don't get the errors on Ubuntu.

@JoshuaLampert
Copy link
Member

What is especially strange is that the errors seem to occur stochastically, see e.g.
https://github.com/trixi-framework/Trixi.jl/actions/runs/6747950983/job/18345234543?pr=1701
https://github.com/trixi-framework/Trixi.jl/actions/runs/6747464311/job/18343680417?pr=1702,
where some tests fail for both runs, but some only for one of the two runs.

@ArseniyKholod
Copy link
Contributor Author

Looks like the error is related to other CI failures we recently hawve in various PRs. I think, we should investigate this further instead of just adapting the tolerances. Locally, I don't get the errors on Ubuntu.

Yeah, I tried on my PR, where I only add one new tutorial, that is executed after this one, so seems to be no way, that it can interfere somehow

@ArseniyKholod
Copy link
Contributor Author

What is especially strange is that the errors seem to occur stochastically, see e.g. https://github.com/trixi-framework/Trixi.jl/actions/runs/6747950983/job/18345234543?pr=1701 https://github.com/trixi-framework/Trixi.jl/actions/runs/6747464311/job/18343680417?pr=1702, where some tests fail for both runs, but some only for one of the two runs.

For me also sometimes tests are passing, sometimes not, could it depend on runner that GitHub use...?

@JoshuaLampert
Copy link
Member

Yeah, I don't know. That is very weird..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants