Fix address sanitizer stack-use-after-scope#9088
Merged
Merged
Conversation
std::make_tuple here will copy the arguments into a tuple so it creates a copy of SmallVector subsliceOffsets and then passes back a tuple with an ArrayRef. The SmallVector object is then out of scope. Bypassing make_tuple means that it uses the underlying AllocationSlice's reference to subsliceOffsets rather than the temporary copy created by make_tuple.
Jokeren
approved these changes
Dec 23, 2025
agron911
added a commit
to agron911/triton
that referenced
this pull request
Apr 24, 2026
…cope (#9088)' (facebookexperimental#1332) Summary: Pull Request resolved: facebookexperimental#1332 This is a cherry-pick of an upstream PR: triton-lang/triton#9088 Upstream commit message: ``` > Fix address sanitizer stack-use-after-scope (#9088) > std::make_tuple here will copy the arguments into a tuple so it creates > a copy of SmallVector subsliceOffsets and then passes back a tuple with > an ArrayRef. The SmallVector object is then out of scope. Bypassing > make_tuple means that it uses the underlying AllocationSlice's reference > to subsliceOffsets rather than the temporary copy created by make_tuple. ``` ***Do not remove the following line from this commit*** Reactor Cherry-pick Revision: a04108b Diff Comparison: https://www.internalfb.com/intern/paste/P2283341704/ --- This diff was generated by running: ``` buck run fbcode//triton/tools/reactor:reactor -- cherrypick --num-commits 1 --no-submit ``` Reviewed By: sfzhu93 Differential Revision: D101982805
meta-codesync Bot
pushed a commit
to facebookexperimental/triton
that referenced
this pull request
Apr 24, 2026
…cope (#9088)' (#1332) Summary: Pull Request resolved: #1332 This is a cherry-pick of an upstream PR: triton-lang/triton#9088 Upstream commit message: ``` > Fix address sanitizer stack-use-after-scope (#9088) > std::make_tuple here will copy the arguments into a tuple so it creates > a copy of SmallVector subsliceOffsets and then passes back a tuple with > an ArrayRef. The SmallVector object is then out of scope. Bypassing > make_tuple means that it uses the underlying AllocationSlice's reference > to subsliceOffsets rather than the temporary copy created by make_tuple. ``` ***Do not remove the following line from this commit*** Reactor Cherry-pick Revision: a04108b Diff Comparison: https://www.internalfb.com/intern/paste/P2283341704/ --- This diff was generated by running: ``` buck run fbcode//triton/tools/reactor:reactor -- cherrypick --num-commits 1 --no-submit ``` Reviewed By: sfzhu93 Differential Revision: D101982805 fbshipit-source-id: b3f6d589c12fa945885f6ae7553e00cae44c525f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::make_tuple here will copy the arguments into a tuple so it creates a copy of SmallVector subsliceOffsets and then passes back a tuple with an ArrayRef. The SmallVector object is then out of scope. Bypassing make_tuple means that it uses the underlying AllocationSlice's reference to subsliceOffsets rather than the temporary copy created by make_tuple.