From 593e168b3b59fefbe8cdba50954c319781466af0 Mon Sep 17 00:00:00 2001 From: Won-Kyu Park Date: Sat, 19 Oct 2024 01:04:40 +0900 Subject: [PATCH 1/2] [BUILD] enable win32 llvm build (#4941) from https://github.com/triton-lang/triton/pull/2757 * fix deprecation warning * use bash shell to fix `az storage ...` console error. * `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency - `"ninja: error: 'C:/Program Files/Microsoft Visual Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by 'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd', missing and no known rule to make it"`. the latest windows llvm build is available at https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows It would be nice to have default llvm;mlir compiler on the official trion build system for someone who trying to develop solve some windows related issue even if windows is not officially supported. p.s.: and I'd like to thank all triton developers for their hard work! --- .github/workflows/llvm-build.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/llvm-build.yml b/.github/workflows/llvm-build.yml index e8daecfb0c58..a2a5a96f3ad8 100644 --- a/.github/workflows/llvm-build.yml +++ b/.github/workflows/llvm-build.yml @@ -32,8 +32,7 @@ jobs: - {runner: 'AlmaLinux 8', runs_on: ['self-hosted', 'CPU'], target-os: 'almalinux', arch: 'x64'} - {runner: 'MacOS X64', runs_on: 'macos-12', target-os: 'macos', arch: 'x64'} - {runner: 'MacOS ARM64', runs_on: 'macos-12', target-os: 'macos', arch: 'arm64'} - # TODO(#2805): add back once the workflow works and runs in comparable time to the other ones - # - {runner: 'Windows Latest', runs_on: 'windows-latest', target-os: 'windows', arch: 'x64'} + - {runner: 'Windows Latest', runs_on: 'windows-latest', target-os: 'windows', arch: 'x64'} steps: @@ -127,7 +126,8 @@ jobs: -DLLVM_BUILD_TOOLS=ON -DLLVM_ENABLE_ASSERTIONS=ON -DMLIR_ENABLE_BINDINGS_PYTHON=ON - -DLLVM_ENABLE_PROJECTS="clang;mlir" + -DLLVM_ENABLE_PROJECTS="mlir;llvm" + -DLLVM_ENABLE_DIA_SDK=OFF -DLLVM_INSTALL_UTILS=ON -DLLVM_TARGETS_TO_BUILD="host;NVPTX;AMDGPU" -DLLVM_ENABLE_TERMINFO=OFF @@ -300,6 +300,7 @@ jobs: - name: Upload LLVM Artifacts to Azure if: ${{ (github.repository == 'triton-lang/triton') }} + shell: bash -el {0} run: | az storage blob upload --account-name oaitriton --auth-mode login --container-name public --file "${{ env.llvm_install_dir }}.tar.gz" --name "llvm-builds/${{ env.llvm_install_dir }}.tar.gz" --overwrite From c848ec620f2e9f39bb788db9623b1a44f4257710 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Tue, 3 Dec 2024 17:21:56 -0800 Subject: [PATCH 2/2] [BUILD] Bump macOS runner to macos-13 (#5324) Right now we are hitting the following issues in https://github.com/triton-lang/triton/actions/runs/12148740919/job/33877869004: > The macOS-12 environment is deprecated, consider switching to > macOS-13, macOS-14 (macos-latest) or macOS-15. For more details, > see https://github.com/actions/runner-images/issues/10721 --- .github/workflows/llvm-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/llvm-build.yml b/.github/workflows/llvm-build.yml index a2a5a96f3ad8..53755ae8ede7 100644 --- a/.github/workflows/llvm-build.yml +++ b/.github/workflows/llvm-build.yml @@ -30,8 +30,8 @@ jobs: - {runner: 'Ubuntu 20.04 ARM64', runs_on: 'ubuntu-20.04', target-os: 'ubuntu', arch: 'arm64'} - {runner: 'CentOS 7', runs_on: ['self-hosted', 'CPU'], target-os: 'centos', arch: 'x64'} - {runner: 'AlmaLinux 8', runs_on: ['self-hosted', 'CPU'], target-os: 'almalinux', arch: 'x64'} - - {runner: 'MacOS X64', runs_on: 'macos-12', target-os: 'macos', arch: 'x64'} - - {runner: 'MacOS ARM64', runs_on: 'macos-12', target-os: 'macos', arch: 'arm64'} + - {runner: 'MacOS X64', runs_on: 'macos-13', target-os: 'macos', arch: 'x64'} + - {runner: 'MacOS ARM64', runs_on: 'macos-13', target-os: 'macos', arch: 'arm64'} - {runner: 'Windows Latest', runs_on: 'windows-latest', target-os: 'windows', arch: 'x64'} steps: