Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to combine enable_fp_fusion and enable_fast_math in upstream triton #50

Open
minjang opened this issue Jul 12, 2024 · 1 comment

Comments

@minjang
Copy link
Collaborator

minjang commented Jul 12, 2024

#41 can be upstreamed? Do more thorough testing for GPU and try to make a PR.

@embg
Copy link
Collaborator

embg commented Jul 12, 2024

One data point: in clang, -ffast-math does enable fp fusion: https://clang.llvm.org/docs/UsersManual.html#cmdoption-ffast-math

This option implies:
...

  • -ffp-contract=fast

Perhaps we can have three settings for enable_fp_fusion? If "enabled" or "disabled", we don't touch it. But if it is set to "auto", then we enable or disable depending on whether fast-math is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants