Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pytests] Add several suits #106

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

Devjiu
Copy link
Collaborator

@Devjiu Devjiu commented Aug 9, 2024

This commits adds to testing several of already working suits.

I've enabled several pytests.

@Devjiu Devjiu force-pushed the dmitriim/enable_passing_tests branch 4 times, most recently from b730fee to 2efbd78 Compare August 12, 2024 14:10
@Devjiu Devjiu requested a review from int3 August 12, 2024 14:20
@Devjiu Devjiu force-pushed the dmitriim/enable_passing_tests branch 3 times, most recently from 747975a to 1cb8d90 Compare August 13, 2024 09:58
@Devjiu
Copy link
Collaborator Author

Devjiu commented Aug 13, 2024

Issue #107

@Devjiu Devjiu linked an issue Aug 13, 2024 that may be closed by this pull request
@Devjiu Devjiu marked this pull request as ready for review August 13, 2024 12:51
@Devjiu Devjiu requested a review from ptillet as a code owner August 13, 2024 12:51
@Devjiu Devjiu force-pushed the dmitriim/enable_passing_tests branch 2 times, most recently from 073a822 to ea518f0 Compare August 13, 2024 17:13
@Devjiu Devjiu requested a review from ienkovich August 13, 2024 17:14
Copy link
Collaborator

@minjang minjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This commits adds to testing several of already working suits.

Signed-off-by: Dmitrii Makarenko <[email protected]>
Enable suits for cpu device.
- language
  - python/test/unit/language/test_random.py
  - python/test/unit/language/test_standard.py
- runtime
  - python/test/unit/runtime/test_bindings.py
  - python/test/unit/runtime/test_cache.py
  - python/test/unit/runtime/test_driver.py
  - python/test/unit/runtime/test_jit.py
  - python/test/unit/runtime/test_launch.py

python/test/unit/runtime/test_cache.py expects creation and usage of
files, that doesn't works with multiple workers.

Signed-off-by: Dmitrii Makarenko <[email protected]>
@Devjiu Devjiu force-pushed the dmitriim/enable_passing_tests branch from ea518f0 to 3ccf910 Compare August 14, 2024 16:08
@Devjiu Devjiu merged commit d3627af into triton-lang:main Aug 14, 2024
2 checks passed
@Devjiu Devjiu deleted the dmitriim/enable_passing_tests branch August 14, 2024 19:27
int3 pushed a commit that referenced this pull request Aug 29, 2024
* [Pytests] Add several suits

This commits adds to testing several of already working suits.

* [Pytest] Support CPU device

Enable suits for cpu device.
- language
  - python/test/unit/language/test_random.py
  - python/test/unit/language/test_standard.py
- runtime
  - python/test/unit/runtime/test_bindings.py
  - python/test/unit/runtime/test_cache.py
  - python/test/unit/runtime/test_driver.py
  - python/test/unit/runtime/test_jit.py
  - python/test/unit/runtime/test_launch.py

python/test/unit/runtime/test_cache.py expects creation and usage of
files, that doesn't works with multiple workers.

---------

Signed-off-by: Dmitrii Makarenko <[email protected]>
minjang pushed a commit that referenced this pull request Sep 22, 2024
* [Pytests] Add several suits

This commits adds to testing several of already working suits.

* [Pytest] Support CPU device

Enable suits for cpu device.
- language
  - python/test/unit/language/test_random.py
  - python/test/unit/language/test_standard.py
- runtime
  - python/test/unit/runtime/test_bindings.py
  - python/test/unit/runtime/test_cache.py
  - python/test/unit/runtime/test_driver.py
  - python/test/unit/runtime/test_jit.py
  - python/test/unit/runtime/test_launch.py

python/test/unit/runtime/test_cache.py expects creation and usage of
files, that doesn't works with multiple workers.

---------

Signed-off-by: Dmitrii Makarenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable more pytests
2 participants