Simplify cleanup logic for renaming tests in BaseConnectorSmokeTest
#27500
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Nov 28, 2025
| throw e; | ||
| } | ||
| assertUpdate("DROP TABLE " + oldTable); | ||
| throw e; |
Member
There was a problem hiding this comment.
I think we should change more. The table will remain if the following assertion with SHOW TABLES or SELECT failed for some reason.
Same for testRenameTableAcrossSchemas.
findepi
reviewed
Nov 28, 2025
| @@ -448,9 +448,8 @@ public void testRenameTable() | |||
| assertUpdate("ALTER TABLE " + oldTable + " RENAME TO " + newTable); | |||
| } | |||
| catch (Throwable e) { | |||
| try (AutoCloseable ignore = () -> assertUpdate("DROP TABLE " + oldTable)) { | |||
| throw e; | |||
Member
There was a problem hiding this comment.
The point here was to preserve e even if the DROP fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: