Revert "Expose /v1/integrations/gateway/metrics for Trino Gateway"

[wendigo]

This reverts commit 1ca42b4.

We need to discuss how to approach exposing endpoints that are meant to be consumed by the external integrations.

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

Revert exposing the Trino Gateway metrics endpoint and remove associated system CPU load reporting from memory management

Enhancements:

• Remove GatewayResource and unregister the /v1/integrations/gateway/metrics endpoint
• Drop systemCpuLoad field from MemoryInfo and LocalMemoryManager

Tests:

• Update memory-related tests to remove systemCpuLoad from MemoryInfo constructors

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request reverts the previously added Trino Gateway metrics endpoint and removes the system CPU load metric from MemoryInfo, updating LocalMemoryManager and test code to align with the revised MemoryInfo API.

Entity relationship diagram for updated MemoryInfo structure

erDiagram
    MEMORYINFO {
        int availableProcessors
        MemoryPoolInfo pool
    }
    MEMORYPOOLINFO {
        string name
        int size
    }
    MEMORYINFO ||--|| MEMORYPOOLINFO : contains

Loading

Class diagram for reverted MemoryInfo and LocalMemoryManager changes

classDiagram
    class MemoryInfo {
        - int availableProcessors
        - MemoryPoolInfo pool
        + MemoryInfo(int availableProcessors, MemoryPoolInfo pool)
        + int getAvailableProcessors()
        + MemoryPoolInfo getPool()
        + String toString()
    }
    class LocalMemoryManager {
        - Supplier<Integer> AVAILABLE_PROCESSORS
        - NodeMemoryConfig config
        - MemoryPool memoryPool
        + LocalMemoryManager(NodeMemoryConfig config)
        + MemoryInfo getInfo()
        + MemoryPool getMemoryPool()
    }
    LocalMemoryManager --> MemoryInfo
    MemoryInfo --> MemoryPoolInfo

Loading

File-Level Changes

Change	Details	Files
Removed systemCpuLoad from MemoryInfo API	Deleted systemCpuLoad field Updated constructor signature Removed getSystemCpuLoad method Adjusted toString output	core/trino-main/src/main/java/io/trino/memory/MemoryInfo.java
Eliminated SYSTEM_CPU_LOAD supplier in LocalMemoryManager	Removed MXBean imports and supplier definition Dropped systemCpuLoad argument in getInfo() Cleaned up unused imports	core/trino-main/src/main/java/io/trino/memory/LocalMemoryManager.java
Reverted Trino Gateway metrics endpoint exposure	Removed JAX-RS binding for GatewayResource Deleted GatewayResource class	core/trino-main/src/main/java/io/trino/server/CoordinatorModule.java core/trino-main/src/main/java/io/trino/server/GatewayResource.java
Updated tests to match new MemoryInfo signature	Removed systemCpuLoad parameter from MemoryInfo instantiations Adjusted helper utilities and scheduler test builders	core/trino-main/src/test/java/io/trino/memory/LowMemoryKillerTestingUtils.java core/trino-main/src/test/java/io/trino/execution/scheduler/faulttolerant/BenchmarkBinPackingNodeAllocator.java core/trino-main/src/test/java/io/trino/execution/scheduler/faulttolerant/TestBinPackingNodeAllocator.java core/trino-main/src/test/java/io/trino/execution/scheduler/faulttolerant/TestExponentialGrowthPartitionMemoryEstimator.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[findepi]

Please add sth like this to the cmt msg

"The endpoint was exposing cluster utilization metrics (memory, load), which are generally useful for observability and also for any other query routing logic. We should expose them in gateway-agnostic manner. Reverting now to unblock release."