From 3844369c968cce0639e1fea1df146dd5df44707b Mon Sep 17 00:00:00 2001 From: Yuya Ebihara Date: Fri, 17 Oct 2025 12:43:48 +0900 Subject: [PATCH] Don't reuse a table name in testCreateTableWithLongColumnName --- .../java/io/trino/testing/BaseConnectorTest.java | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java b/testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java index 42db2c01fbf3..bad470fd331c 100644 --- a/testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java +++ b/testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java @@ -3862,7 +3862,7 @@ public void testCreateTableWithLongColumnName() { skipTestUnless(hasBehavior(SUPPORTS_CREATE_TABLE)); - String tableName = "test_long_column" + randomNameSuffix(); + String tableNameWithValidColumnLength = "test_long_column" + randomNameSuffix(); String baseColumnName = "col"; int maxLength = maxColumnNameLength() @@ -3870,18 +3870,19 @@ public void testCreateTableWithLongColumnName() .orElse(65536 + 5); String validColumnName = baseColumnName + "z".repeat(maxLength - baseColumnName.length()); - assertUpdate("CREATE TABLE " + tableName + " (" + validColumnName + " bigint)"); - assertThat(columnExists(tableName, validColumnName)).isTrue(); - assertUpdate("DROP TABLE " + tableName); + assertUpdate("CREATE TABLE " + tableNameWithValidColumnLength + " (" + validColumnName + " bigint)"); + assertThat(columnExists(tableNameWithValidColumnLength, validColumnName)).isTrue(); + assertUpdate("DROP TABLE " + tableNameWithValidColumnLength); if (maxColumnNameLength().isEmpty()) { return; } + String tableNameWithInvalidColumnLength = "test_long_column" + randomNameSuffix(); String invalidColumnName = validColumnName + "z"; - assertThatThrownBy(() -> assertUpdate("CREATE TABLE " + tableName + " (" + invalidColumnName + " bigint)")) + assertThatThrownBy(() -> assertUpdate("CREATE TABLE " + tableNameWithInvalidColumnLength + " (" + invalidColumnName + " bigint)")) .satisfies(this::verifyColumnNameLengthFailurePermissible); - assertThat(getQueryRunner().tableExists(getSession(), tableName)).isFalse(); + assertThat(getQueryRunner().tableExists(getSession(), tableNameWithInvalidColumnLength)).isFalse(); } // TODO: Add test for CREATE TABLE AS SELECT with long column name