Support reading from CSV tables with null escape and quote characters #26619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcarmonagonzalez
force-pushed
the
csv-quote-escape-fix
branch
from
4d94083 to
dd87eeb
Compare
mcarmonagonzalez
force-pushed
the
csv-quote-escape-fix
branch
2 times, most recently
from
077d1c7 to
511b59f
Compare
Hive OpenCSV allows for setting both the escape and quote character to the null character to indicate escaping/quoting is disabled. The native CSV reader is supposed to be a compatible reimplementation of the Hive OpenCSV reader so this behavior must also be supported.
mcarmonagonzalez
force-pushed
the
csv-quote-escape-fix
branch
from
511b59f to
74babe3
Compare
wendigo
approved these changes
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #16754 and #18952, this change maintains a "bug" from the original OpenCSV reader in the native CSV reader. In the original CSVParser logic , quote/escape characters were not considered equivalent if either of the characters was the null character
\0. This is because setting both of them to the null character would disable both quoting and escaping and is a valid configuration.Even though having both quoting and escaping disabled could lead to data not round tripping, support for reading from tables with the same null quote/escape character should be maintained in the native CSV reader implementation.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text: