Implement streamRelationColumns in BlackHole #26427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Aug 17, 2025
| } | ||
|
|
||
| @Override | ||
| public Iterator<RelationColumnsMetadata> streamRelationColumns(ConnectorSession session, Optional<String> schemaName, UnaryOperator<Set<SchemaTableName>> relationFilter) |
Member
There was a problem hiding this comment.
This line is too long. Please put parameters on separate lines. Also, synchronized looks missing.
Contributor
Author
There was a problem hiding this comment.
Why need synchronized here?
Member
There was a problem hiding this comment.
Not specific here. For instance, BlackHoleMetadata.renameTable method contains tables.remove & tables.put calls. Streaming columns may miss tables in the middle of renaming. No need to fix as it's pre-existing though.
chenjian2664
force-pushed
the
blockhole_stream_columns
branch
from
903e34f to
87dcd36
Compare
ebyhr
reviewed
Aug 17, 2025
plugin/trino-blackhole/src/main/java/io/trino/plugin/blackhole/BlackHoleMetadata.java
Show resolved
Hide resolved
ebyhr
approved these changes
Aug 17, 2025
chenjian2664
force-pushed
the
blockhole_stream_columns
branch
from
87dcd36 to
ee2216b
Compare
ebyhr
force-pushed
the
blockhole_stream_columns
branch
from
ee2216b to
eeb7867
Compare
Contributor
Author
|
Thank you @ebyhr for clean ups of the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: