-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Document bigquery.arrow-serialization.max-allocation property
#26409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document bigquery.arrow-serialization.max-allocation property
#26409
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
f8dfb50 to
47ccf1c
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
bigquery.arrow-serialization.max-allocation property
ebyhr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you already submitted CLA?
Yes, CLA has been submitted from my end today. Waiting for the team to review and approve. |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
My CLA doc has been rejected as they need physical sign. I will resubmit it today. |
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@archangel2018 it takes quite long time, could you check if you sent right username and email? |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Description
This pull request updates the documentation for the BigQuery connector to include the
bigquery.arrow-serialization.max-allocationproperty. This property allows users to increase the maximum memory usage for the Apache Arrow buffer allocator, which can help prevent memory leaks and out-of-memory errors.Additional context and related issues
The issue is linked to a bug in the BigQuery connector's Arrow serialization process. Despite ample memory resources on the worker nodes, the Arrow allocator would fail to reserve memory, leading to an
OutOfMemoryException. Disabling Arrow serialization (bigquery.arrow-serialization.enabled=false) resolved the issue but sacrificed performance. This fix allows us to keep the performance benefits of Arrow serialization while preventing memory allocation failures.Fixes #26400
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: