Skip to content

Conversation

@archangel2018
Copy link
Contributor

@archangel2018 archangel2018 commented Aug 14, 2025


Description

This pull request updates the documentation for the BigQuery connector to include the bigquery.arrow-serialization.max-allocation property. This property allows users to increase the maximum memory usage for the Apache Arrow buffer allocator, which can help prevent memory leaks and out-of-memory errors.


Additional context and related issues

The issue is linked to a bug in the BigQuery connector's Arrow serialization process. Despite ample memory resources on the worker nodes, the Arrow allocator would fail to reserve memory, leading to an OutOfMemoryException. Disabling Arrow serialization (bigquery.arrow-serialization.enabled=false) resolved the issue but sacrificed performance. This fix allows us to keep the performance benefits of Arrow serialization while preventing memory allocation failures.

Fixes #26400


Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot
Copy link

cla-bot bot commented Aug 14, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the docs label Aug 14, 2025
@raunaqmorarka raunaqmorarka requested review from ebyhr and wendigo August 14, 2025 09:04
@ebyhr ebyhr force-pushed the docs-bigquery-arrow-config branch from f8dfb50 to 47ccf1c Compare August 16, 2025 05:31
@cla-bot
Copy link

cla-bot bot commented Aug 16, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr ebyhr changed the title Update bigquery.md - bigquery.arrow-serialization.max-allocation added to docs Document bigquery.arrow-serialization.max-allocation property Aug 16, 2025
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you already submitted CLA?

@archangel2018
Copy link
Contributor Author

Have you already submitted CLA?

Yes, CLA has been submitted from my end today. Waiting for the team to review and approve.

@raunaqmorarka
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Aug 19, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link

cla-bot bot commented Aug 19, 2025

The cla-bot has been summoned, and re-checked this pull request!

@raunaqmorarka
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Aug 21, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link

cla-bot bot commented Aug 21, 2025

The cla-bot has been summoned, and re-checked this pull request!

@archangel2018
Copy link
Contributor Author

My CLA doc has been rejected as they need physical sign. I will resubmit it today.

@github-actions
Copy link

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions bot added the stale label Sep 15, 2025
@raunaqmorarka
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Sep 15, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link

cla-bot bot commented Sep 15, 2025

The cla-bot has been summoned, and re-checked this pull request!

@github-actions github-actions bot removed the stale label Sep 16, 2025
@chenjian2664
Copy link
Contributor

@archangel2018 it takes quite long time, could you check if you sent right username and email?

@raunaqmorarka
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 17, 2025
@cla-bot
Copy link

cla-bot bot commented Sep 17, 2025

The cla-bot has been summoned, and re-checked this pull request!

@raunaqmorarka raunaqmorarka merged commit ca5021a into trinodb:master Sep 17, 2025
8 checks passed
@github-actions github-actions bot added this to the 477 milestone Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

BQ connector - Unable to allocate buffer of size

4 participants