Record error message in S3FileSystem#deleteObjects #26390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
reviewed
Aug 12, 2025
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3FileSystem.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
raunaq/s3-delete-error
branch
from
b4fd654 to
d3edada
Compare
raunaqmorarka
requested review from
Copilot,
ebyhr and
electrum
and removed request for
ebyhr and
electrum
raunaqmorarka
force-pushed
the
raunaq/s3-delete-error
branch
from
d3edada to
c8fa1d8
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error handling in the S3FileSystem's deleteObjects method by improving error message recording. When S3 delete operations fail, the system now captures both the error message and error code instead of just the error code.
- Enhanced error message formatting to include both message and code when available
- Added null check for error message to handle cases where S3 returns only error codes
- Improved debugging capability by providing more detailed error information
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3FileSystem.java
Show resolved
Hide resolved
wendigo
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Record error message in S3FileSystem#deleteObjects
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: