Reuse compiled PagesIndexOrdering #26283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
approved these changes
Aug 1, 2025
core/trino-main/src/main/java/io/trino/operator/function/TableFunctionOperator.java
Outdated
Show resolved
Hide resolved
Having a sub-range sort method that doesn't reuse the compiled PagesIndexOrdering can encourage inefficient patterns that should instead reuse an instance.
pettyjamesm
force-pushed
the
reuse-compiled-pages-index-ordering
branch
from
6214380 to
914e437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids calling into code generation logic inside of
PagesIndex#sort(List<Integer>, List<SortOrder>, int startIndex, int endIndex)by refactoring existing usages to eagerly create and then keep an instance ofPagesIndexOrderingfor reuse. Some scenarios (such as window operators) could repeatedly call into the code generation path which creates cache contention and a severe performance hazard if the entry was evicted from cache between calls.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: