Skip to content

Conversation

@ebyhr
Copy link
Member

@ebyhr ebyhr commented Jul 23, 2025

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jul 23, 2025
@ebyhr ebyhr requested review from chenjian2664 and wendigo July 23, 2025 04:20
@ebyhr ebyhr merged commit cec39cd into trinodb:master Jul 23, 2025
15 checks passed
@ebyhr ebyhr deleted the ebi/mysql-el-record branch July 23, 2025 10:53
@github-actions github-actions bot added this to the 477 milestone Jul 23, 2025
import java.util.Optional;
import java.util.stream.Stream;

public class RecordAndAnnotatedConstructorMapper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use ConstructorMapper directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires a row mapper registration per record class, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and JDBI has specialized ways to register ConstructorMapper specifically, like @RegisterConstructorMapper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants