Handle already closed JDBC connections gracefully #26175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjian2664
changed the title
IllegalStateException when closing already closed JDBC con…IllegalStateException when closing closed JDBC connection
chenjian2664
force-pushed
the
fix_connection_close
branch
from
0065339 to
a843b94
Compare
ebyhr
reviewed
Jul 11, 2025
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcPageSink.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
fix_connection_close
branch
3 times, most recently
from
b9892a6 to
9ab410b
Compare
ebyhr
reviewed
Jul 14, 2025
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/ConnectionAlreadyClosedException.java
Show resolved
Hide resolved
chenjian2664
force-pushed
the
fix_connection_close
branch
from
9ab410b to
2859105
Compare
Introduces `ConnectionAlreadyClosedException` to signal attempts to use closed JDBC connections. Updates `LazyConnectionFactory` to throw this exception when a closed connection is accessed, and updates `JdbcPageSink` to handle this exception without error
chenjian2664
force-pushed
the
fix_connection_close
branch
from
2859105 to
05013c3
Compare
chenjian2664
changed the title
IllegalStateException when closing closed JDBC connection
ebyhr
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
ConnectionAlreadyClosedExceptionto signal attempts touse closed JDBC connections. Updates
LazyConnectionFactoryto throwthis exception when a closed connection is accessed, and updates
JdbcPageSinkto handle this exception without errorDescription
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: