Skip to content

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Jul 9, 2025

This moves to unshaded guice dependency so that new ASM version can be picked up instead of the shaded one. This makes guice fully functional in the new JDKs.

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

This moves to unshaded guice dependency so that new ASM version can be picked
up instead of the shaded one. This makes guice fully functional in the new JDKs.
@cla-bot cla-bot bot added the cla-signed label Jul 9, 2025
@github-actions github-actions bot added jdbc Relates to Trino JDBC driver hudi Hudi connector iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector bigquery BigQuery connector mongodb MongoDB connector snowflake Snowflake connector cassandra Cassandra connector clickhouse ClickHouse connector druid Druid connector duckdb DuckDB connector elasticsearch Elasticsearch connector exasol Exasol connector faker Faker connector google-sheets Google Sheets connector ignite Ignite connector kafka Kafka connector loki Loki connector mariadb MariaDB connector memory Memory connector mysql MySQL connector opensearch OpenSearch connector oracle Oracle connector pinot Pinot connector postgresql PostgreSQL connector prometheus Prometheus connector redis Redis connector labels Jul 9, 2025
@github-actions github-actions bot added redshift Redshift connector singlestore SingleStore connector sqlserver SQLServer connector vertica Vertica connector labels Jul 9, 2025
@wendigo
Copy link
Contributor Author

wendigo commented Jul 9, 2025

Previously shaded dependency definition was removed and dependency is now banned (classes classifier is allowed)

@wendigo wendigo merged commit 8b445f5 into master Jul 9, 2025
203 of 206 checks passed
@wendigo wendigo deleted the serafin/guice-classes-without-asm branch July 9, 2025 10:19
@github-actions github-actions bot added this to the 477 milestone Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bigquery BigQuery connector cassandra Cassandra connector cla-signed clickhouse ClickHouse connector delta-lake Delta Lake connector druid Druid connector duckdb DuckDB connector elasticsearch Elasticsearch connector exasol Exasol connector faker Faker connector google-sheets Google Sheets connector hive Hive connector hudi Hudi connector iceberg Iceberg connector ignite Ignite connector jdbc Relates to Trino JDBC driver kafka Kafka connector loki Loki connector mariadb MariaDB connector memory Memory connector mongodb MongoDB connector mysql MySQL connector opensearch OpenSearch connector oracle Oracle connector pinot Pinot connector postgresql PostgreSQL connector prometheus Prometheus connector redis Redis connector redshift Redshift connector singlestore SingleStore connector snowflake Snowflake connector sqlserver SQLServer connector vertica Vertica connector

Development

Successfully merging this pull request may close these issues.

3 participants