Use RunLengthEncodedBlock for null column appends
#26140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces manual null appending with `RunLengthEncodedBlock` when adding columns with null values
wendigo
approved these changes
Jul 7, 2025
samarsar
reviewed
Jul 9, 2025
| BlockBuilder builder = type.createBlockBuilder(null, page.getPositionCount()); | ||
| IntStream.range(0, page.getPositionCount()).forEach(_ -> builder.appendNull()); | ||
| page = page.appendColumn(builder.build()); | ||
| page = page.appendColumn(RunLengthEncodedBlock.create(columnTypes.get(i), null, page.getPositionCount())); |
There was a problem hiding this comment.
Wanting to confirm is this the correct variable? Seems like j is iterating over column indexes while i is iterating over pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces manual null appending with
RunLengthEncodedBlockwhen adding columns with null valuesDescription
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: