Avoid relying on org.apache.parquet.format.RowGroup.getFile_offset #26064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
requested review from
Praveen2112,
chenjian2664,
ebyhr,
findinpath,
jinyangli34 and
losipiuk
raunaqmorarka
force-pushed
the
raunaq/pqr-offset-fix
branch
from
ca90e45 to
6b4c808
Compare
Praveen2112
reviewed
Jun 25, 2025
lib/trino-parquet/src/main/java/io/trino/parquet/metadata/ParquetMetadata.java
Outdated
Show resolved
Hide resolved
Certain parquet writers like pyarrow can set this offset incorrectly. That can lead to the parquet reader not idenitfying the row groups within a split correctly. This code is changed to rely on first page offset in ColumnChunk instead. This also removes logic in PredicateUtils#getFilteredRowGroups that is now redudant
raunaqmorarka
force-pushed
the
raunaq/pqr-offset-fix
branch
from
6b4c808 to
486c970
Compare
Praveen2112
approved these changes
Jun 25, 2025
lib/trino-parquet/src/main/java/io/trino/parquet/predicate/PredicateUtils.java
Show resolved
Hide resolved
chenjian2664
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Certain parquet writers like pyarrow can set this offset incorrectly.
That can lead to the parquet reader not idenitfying the row groups
within a split correctly. This code is changed to rely on first page
offset in ColumnChunk instead.
Additional context and related issues
Fixes #26058
Related to #24618
Newer versions of pyarrow (tested parquet-cpp-arrow version 20.0.0) don't have this problem, the file showing this problem is using
parquet-cpp-arrow version 5.0.0Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: