From 4775ac8f35477467441770bade09c81bd9365740 Mon Sep 17 00:00:00 2001 From: chenjian2664 Date: Thu, 19 Jun 2025 09:24:48 +0800 Subject: [PATCH] Wrapping `parquetColumnFieldsBuilder` with `ImmutableList.copyOf` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously, `parquetColumnFieldsBuilder` was passed directly to `createParquetReader`, which was confusing as it looked like a builder but wasn’t clear where `.build()` was called. Wrapping it with `ImmutableList.copyOf` makes the intent explicit and avoids the impression that the method accepts a builder directly. --- .../io/trino/plugin/hive/parquet/ParquetPageSourceFactory.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSourceFactory.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSourceFactory.java index 08443c5abbc9..a8df03061c89 100644 --- a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSourceFactory.java +++ b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSourceFactory.java @@ -526,7 +526,7 @@ public static ConnectorPageSource createParquetPageSource( coercer.map(Function.identity())); } } - ParquetReader parquetReader = parquetReaderProvider.createParquetReader(parquetColumnFieldsBuilder, appendRowNumberColumn); + ParquetReader parquetReader = parquetReaderProvider.createParquetReader(ImmutableList.copyOf(parquetColumnFieldsBuilder), appendRowNumberColumn); ConnectorPageSource pageSource = new ParquetPageSource(parquetReader); return transforms.build(pageSource); }