Wrapping parquetColumnFieldsBuilder with ImmutableList.copyOf
#26032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
I don't think the original name was misleading as the variable is used like a builder. |
Contributor
Author
|
It confuses me when I look at this line: I was trying to get to know why the method accept the builder, and then to follow the code to see where does the parquetColumnFieldsBuilder actual calling build method. |
Member
|
The new name is misleading in for loop as the value is not finalized there. |
Previously, `parquetColumnFieldsBuilder` was passed directly to `createParquetReader`, which was confusing as it looked like a builder but wasn’t clear where `.build()` was called. Wrapping it with `ImmutableList.copyOf` makes the intent explicit and avoids the impression that the method accepts a builder directly.
ebyhr
changed the title
parquetColumnFieldsBuilder with ImmutableList.copyOf
ebyhr
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The variable name ending with builder is misleading—it actually holds a list, not a builder.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.