Random improvements #26006
Merged
Random improvements #26006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Jun 13, 2025
core/trino-main/src/main/java/io/trino/server/ServerConfig.java
Outdated
Show resolved
Hide resolved
| return getLong(getTpchColumn(field)); | ||
| } | ||
|
|
||
| private long getLong(TpchColumn<E> tpchColumn) |
Member
There was a problem hiding this comment.
What was wrong with the existing code here ?
core/trino-main/src/main/java/io/trino/server/ServerConfig.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/random-improvements
branch
from
8c6bb46 to
41cfe15
Compare
raunaqmorarka
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR implements several random improvements, including code cleanup and better use of deterministic collection patterns. Key changes include:
- Inlining and refactoring of getter methods in TpchRecordSet.java to remove redundant private methods.
- Simplification of block array size calculation in BlockUtil.java using a clamp helper and removal of unused methods.
- Updating split ordering in SplitAssignment.java to use a sorted collection for deterministic scheduling.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugin/trino-tpch/src/main/java/io/trino/plugin/tpch/TpchRecordSet.java | Inlined getter methods and changed handling of long values in getTrinoObject. |
| core/trino-spi/src/main/java/io/trino/spi/block/BlockUtil.java | Replaced manual clamping with a clamp helper and removed unused helper methods. |
| core/trino-main/src/main/java/io/trino/execution/SplitAssignment.java | Updated the splits collection to use an immutable sorted set for deterministic ordering. |
Comments suppressed due to low confidence (1)
plugin/trino-tpch/src/main/java/io/trino/plugin/tpch/TpchRecordSet.java:264
- For fields where the expected Java type is long, using 'getInteger(row)' may return an incorrect value or lose precision. Consider verifying that this change is intentional or using a method that returns a long.
return column.getInteger(row);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: