Skip to content

Upgrade docker-images to 116 #25995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2025
Merged

Upgrade docker-images to 116 #25995

merged 2 commits into from
Jun 15, 2025

Conversation

@chenjian2664
Copy link
Contributor

@chenjian2664 chenjian2664 commented Jun 12, 2025 •
edited by ebyhr
Loading

Description

Update Spark from 3 to 4 in Delta Lake docker image.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jun 12, 2025
@chenjian2664
Copy link
Contributor Author

chenjian2664 commented Jun 12, 2025

follow up of : trinodb/docker-images#242

@chenjian2664 chenjian2664 marked this pull request as draft June 12, 2025 05:14
@chenjian2664 chenjian2664 force-pushed the docker-upgrade branch 2 times, most recently from 7f49b19 to 62d6147 Compare June 13, 2025 03:23
@chenjian2664
Copy link
Contributor Author

chenjian2664 commented Jun 13, 2025

I see you triggle the release in docker-images repository.
why we got org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=ghcr.io/trinodb/testing/spark4-delta:114 here

@ebyhr
Copy link
Member

ebyhr commented Jun 13, 2025

@chenjian2664 You need to upgrade to 116 🙂 https://github.com/trinodb/docker-images/commits/master/

@chenjian2664 chenjian2664 changed the title Upgrade docker-images to 114 Upgrade docker-images to 116 Jun 13, 2025
@chenjian2664 chenjian2664 marked this pull request as ready for review June 13, 2025 07:33
@chenjian2664 chenjian2664 requested a review from ebyhr June 13, 2025 07:33
@ebyhr
Copy link
Member

ebyhr commented Jun 13, 2025 •
edited
Loading

I believe CI failure is related to this bump. Could you fix it?

@chenjian2664
Copy link
Contributor Author

chenjian2664 commented Jun 13, 2025

Do you mean changes in trinodb/docker-images#242 ? I don't see it touches the polaris

@ebyhr
Copy link
Member

ebyhr commented Jun 13, 2025 •
edited
Loading

@chenjian2664 Polaris docker image builds based on the latest repository https://github.com/trinodb/docker-images/blob/master/testing/polaris-catalog/Dockerfile#L15

I guess we need to fix TestingPolarisCatalog#createCatalog method.

@github-actions github-actions bot added the iceberg Iceberg connector label Jun 14, 2025
@github-actions github-actions bot added the delta-lake Delta Lake connector label Jun 15, 2025
@chenjian2664 @ebyhr
Upgrade docker-images to 116
77ada06
@chenjian2664 @ebyhr
Add status code check to fail fast on Polaris catalog creation
6913001 
Validate the HTTP status code when creating the Polaris catalog to ensure
test failures are reported early if catalog creation fails.
@ebyhr ebyhr merged commit b2548b8 into trinodb:master Jun 15, 2025
26 of 67 checks passed
@github-actions github-actions bot added this to the 477 milestone Jun 15, 2025
@ebyhr ebyhr mentioned this pull request Aug 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebyhr ebyhr ebyhr approved these changes

Assignees

@chenjian2664 chenjian2664

Labels

cla-signed delta-lake Delta Lake connector iceberg Iceberg connector

Milestone

477

Development

Successfully merging this pull request may close these issues.

2 participants

@chenjian2664 @ebyhr