-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Make WITH SESSION appear before FUNCTION #24902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you also expand the docs a bit .. link to it from session properties doc and add an example somewhere in the selecd.md |
|
Alternatively: as we have three distinct cases: |
|
let me know @martint which option do you prefer |
d98df14 to
22c638e
Compare
2e9eea5 to
dafc6f9
Compare
martint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're going to have to adjust the test in TestSqlParser.testWithSessionAndFunction() accordingly
b389ba3 to
6c99002
Compare
6c99002 to
2941983
Compare
0719941 to
452bbe7
Compare
This is unambigous if the WITH SESSION always appears before WITH FUNCTION as the specified session properties are always visible to the function definition and during function execution in the query body.
452bbe7 to
c4325f7
Compare
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: