Skip to content

Conversation

@losipiuk
Copy link
Member

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@losipiuk losipiuk requested a review from nineinchnick January 31, 2025 15:15
@cla-bot cla-bot bot added the cla-signed label Jan 31, 2025
@losipiuk losipiuk requested a review from wendigo January 31, 2025 15:15
@github-actions github-actions bot added the faker Faker connector label Jan 31, 2025
@losipiuk losipiuk force-pushed the lukaszos/add-faker-fte-query-runner-643b2f branch from 613a50f to e39c222 Compare January 31, 2025 16:17
@losipiuk
Copy link
Member Author

losipiuk commented Jan 31, 2025 via email

@losipiuk losipiuk force-pushed the lukaszos/add-faker-fte-query-runner-643b2f branch from e39c222 to 898dc2d Compare January 31, 2025 17:37
@losipiuk losipiuk requested a review from nineinchnick January 31, 2025 17:37
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we only support long steps, maybe no need to check the types here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was failing without that

@losipiuk losipiuk force-pushed the lukaszos/add-faker-fte-query-runner-643b2f branch from 898dc2d to bea29e9 Compare February 3, 2025 17:16
@losipiuk losipiuk merged commit 4a5e5a1 into trinodb:master Feb 3, 2025
19 checks passed
@github-actions github-actions bot added this to the 470 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed faker Faker connector

Development

Successfully merging this pull request may close these issues.

3 participants