From e63ee62bb62b83fcd39dd3e76bb85a26baeb1dcd Mon Sep 17 00:00:00 2001 From: Ashhar Hasan Date: Fri, 10 Jan 2025 14:12:00 +0530 Subject: [PATCH] Fix query runners failing to expose local ports The logic was mistakenly inverted in a99d96ece15113d4edf204f5a5345b26f5c9721f. --- .../main/java/io/trino/testing/containers/TestContainers.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testing/trino-testing-containers/src/main/java/io/trino/testing/containers/TestContainers.java b/testing/trino-testing-containers/src/main/java/io/trino/testing/containers/TestContainers.java index 9f9e0886fd34..956c782ae43a 100644 --- a/testing/trino-testing-containers/src/main/java/io/trino/testing/containers/TestContainers.java +++ b/testing/trino-testing-containers/src/main/java/io/trino/testing/containers/TestContainers.java @@ -73,7 +73,7 @@ public static String getPathFromClassPathResource(String resourcePath) public static void exposeFixedPorts(GenericContainer container) { - checkState(isEnvSet("CONTINUOUS_INTEGRATION"), "" + + checkState(!isEnvSet("CONTINUOUS_INTEGRATION"), "" + "Exposing fixed ports should not be used in regular test code. This could break parallel test execution. " + "This method is supposed to be invoked from local development helpers only e.g. QueryRunner.main(), " + "hence it should never run on CI");