Skip to content

Conversation

@nineinchnick
Copy link
Member

@nineinchnick nineinchnick commented Oct 31, 2024

Description

Add a random_string function in the Faker connector that makes it easier to test generator expressions, before using it in column properties.

Additional context and related issues

Release notes

() This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Add a `random_string` function in the Faker connector that makes it
easier to test generator expressions, before using it in column
properties.
@wendigo wendigo merged commit 05a4e61 into trinodb:master Oct 31, 2024
18 checks passed
@nineinchnick nineinchnick deleted the faker-random-string-func branch October 31, 2024 11:26
@github-actions github-actions bot added this to the 465 milestone Oct 31, 2024
@ebyhr
Copy link
Member

ebyhr commented Nov 1, 2024

This PR should have received a syntax review by @martint.

@nineinchnick
Copy link
Member Author

Why? It's not a global function

@ebyhr
Copy link
Member

ebyhr commented Nov 1, 2024

@nineinchnick #16205 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants