From 54f14b059e33f7ea282abaffb43af0ecb77769b0 Mon Sep 17 00:00:00 2001 From: Piotr Findeisen Date: Thu, 14 Feb 2019 22:33:01 +0100 Subject: [PATCH] Remove incorrect check in QueryBuilder It's engine's duty not to create range-based `TupleDomain`s for non-orderable types, therefore the check was redundant. Even for a non-orderable type, engine can create an equality-based (enumerated) `TupleDomain`, so the check was not correct. --- .../src/main/java/io/prestosql/plugin/jdbc/QueryBuilder.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/QueryBuilder.java b/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/QueryBuilder.java index 64e9dc5cd8fe..d238a2c69df0 100644 --- a/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/QueryBuilder.java +++ b/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/QueryBuilder.java @@ -31,7 +31,6 @@ import java.util.List; import java.util.Optional; -import static com.google.common.base.Preconditions.checkArgument; import static com.google.common.base.Preconditions.checkState; import static com.google.common.base.Strings.isNullOrEmpty; import static com.google.common.collect.Iterables.getOnlyElement; @@ -183,8 +182,6 @@ private List toConjuncts(JdbcClient client, ConnectorSession session, Li private String toPredicate(String columnName, Domain domain, JdbcColumnHandle column, List accumulator) { - checkArgument(domain.getType().isOrderable(), "Domain type must be orderable"); - if (domain.getValues().isNone()) { return domain.isNullAllowed() ? quote(columnName) + " IS NULL" : ALWAYS_FALSE; }