diff --git a/core/trino-main/src/main/java/io/trino/tracing/TracingConnectorMetadata.java b/core/trino-main/src/main/java/io/trino/tracing/TracingConnectorMetadata.java index 9c90f5576e51..ea16c873e988 100644 --- a/core/trino-main/src/main/java/io/trino/tracing/TracingConnectorMetadata.java +++ b/core/trino-main/src/main/java/io/trino/tracing/TracingConnectorMetadata.java @@ -687,18 +687,6 @@ public boolean supportsMissingColumnsOnInsert() } } - @Override - public Optional finishInsert(ConnectorSession session, ConnectorInsertTableHandle insertHandle, Collection fragments, Collection computedStatistics) - { - Span span = startSpan("finishInsert"); - if (span.isRecording()) { - span.setAttribute(TrinoAttributes.HANDLE, insertHandle.toString()); - } - try (var _ = scopedSpan(span)) { - return delegate.finishInsert(session, insertHandle, fragments, computedStatistics); - } - } - @Override public Optional finishInsert(ConnectorSession session, ConnectorInsertTableHandle insertHandle, List sourceTableHandles, Collection fragments, Collection computedStatistics) { diff --git a/core/trino-main/src/test/java/io/trino/connector/MockConnector.java b/core/trino-main/src/test/java/io/trino/connector/MockConnector.java index caf234d25ca3..88b461d14cdd 100644 --- a/core/trino-main/src/test/java/io/trino/connector/MockConnector.java +++ b/core/trino-main/src/test/java/io/trino/connector/MockConnector.java @@ -815,7 +815,12 @@ public boolean supportsMissingColumnsOnInsert() } @Override - public Optional finishInsert(ConnectorSession session, ConnectorInsertTableHandle insertHandle, Collection fragments, Collection computedStatistics) + public Optional finishInsert( + ConnectorSession session, + ConnectorInsertTableHandle insertHandle, + List sourceTableHandles, + Collection fragments, + Collection computedStatistics) { return Optional.empty(); } diff --git a/core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java b/core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java index 2ca7fc03141d..6d2a9c0e7d8c 100644 --- a/core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java +++ b/core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java @@ -817,17 +817,6 @@ default boolean supportsMissingColumnsOnInsert() return false; } - /** - * Finish insert query - * - * @deprecated use {@link #finishInsert(ConnectorSession, ConnectorInsertTableHandle, List, Collection, Collection)} - */ - @Deprecated - default Optional finishInsert(ConnectorSession session, ConnectorInsertTableHandle insertHandle, Collection fragments, Collection computedStatistics) - { - throw new TrinoException(GENERIC_INTERNAL_ERROR, "ConnectorMetadata beginInsert() is implemented without finishInsert()"); - } - /** * Finish insert query */ @@ -838,8 +827,7 @@ default Optional finishInsert( Collection fragments, Collection computedStatistics) { - // Delegate to deprecated SPI to not break existing connectors - return finishInsert(session, insertHandle, fragments, computedStatistics); + throw new TrinoException(GENERIC_INTERNAL_ERROR, "ConnectorMetadata beginInsert() is implemented without finishInsert()"); } /** diff --git a/lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/classloader/ClassLoaderSafeConnectorMetadata.java b/lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/classloader/ClassLoaderSafeConnectorMetadata.java index 68f78b03a5f5..2f38aedc26c3 100644 --- a/lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/classloader/ClassLoaderSafeConnectorMetadata.java +++ b/lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/classloader/ClassLoaderSafeConnectorMetadata.java @@ -611,14 +611,6 @@ public boolean supportsMissingColumnsOnInsert() } } - @Override - public Optional finishInsert(ConnectorSession session, ConnectorInsertTableHandle insertHandle, Collection fragments, Collection computedStatistics) - { - try (ThreadContextClassLoader _ = new ThreadContextClassLoader(classLoader)) { - return delegate.finishInsert(session, insertHandle, fragments, computedStatistics); - } - } - @Override public Optional finishInsert(ConnectorSession session, ConnectorInsertTableHandle insertHandle, List sourceTableHandles, Collection fragments, Collection computedStatistics) { diff --git a/plugin/trino-blackhole/src/main/java/io/trino/plugin/blackhole/BlackHoleMetadata.java b/plugin/trino-blackhole/src/main/java/io/trino/plugin/blackhole/BlackHoleMetadata.java index 8393af94ace7..23c233ff88df 100644 --- a/plugin/trino-blackhole/src/main/java/io/trino/plugin/blackhole/BlackHoleMetadata.java +++ b/plugin/trino-blackhole/src/main/java/io/trino/plugin/blackhole/BlackHoleMetadata.java @@ -380,7 +380,12 @@ public ConnectorInsertTableHandle beginInsert(ConnectorSession session, Connecto } @Override - public Optional finishInsert(ConnectorSession session, ConnectorInsertTableHandle insertHandle, Collection fragments, Collection computedStatistics) + public Optional finishInsert( + ConnectorSession session, + ConnectorInsertTableHandle insertHandle, + List sourceTableHandles, + Collection fragments, + Collection computedStatistics) { return Optional.empty(); } diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java index 9b8ac1488af2..4689734043f4 100644 --- a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java +++ b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java @@ -2169,12 +2169,6 @@ else if (isTransactional) { return result; } - @Override - public Optional finishInsert(ConnectorSession session, ConnectorInsertTableHandle insertHandle, Collection fragments, Collection computedStatistics) - { - throw new UnsupportedOperationException("This method is not supported because finishInsert with sourceTableHandles is implemented instead"); - } - @Override public Optional finishInsert( ConnectorSession session, diff --git a/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java b/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java index 5bea8c4aeeb7..2baaf3cc163b 100644 --- a/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java +++ b/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java @@ -1043,7 +1043,7 @@ public Optional finishCreateTable(ConnectorSession sess return Optional.empty(); } - return finishInsert(session, icebergTableHandle, fragments, computedStatistics); + return finishInsert(session, icebergTableHandle, ImmutableList.of(), fragments, computedStatistics); } catch (AlreadyExistsException e) { // May happen when table has been already created concurrently. @@ -1171,7 +1171,12 @@ private static List getSupportedSortFields(Schema schema, SortOr } @Override - public Optional finishInsert(ConnectorSession session, ConnectorInsertTableHandle insertHandle, Collection fragments, Collection computedStatistics) + public Optional finishInsert( + ConnectorSession session, + ConnectorInsertTableHandle insertHandle, + List sourceTableHandles, + Collection fragments, + Collection computedStatistics) { List commitTasks = fragments.stream() .map(slice -> commitTaskCodec.fromJson(slice.getBytes()))