Improve docs for HTTP server config #22166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pluies
approved these changes
May 27, 2024
dain
reviewed
Jun 1, 2024
Member
There was a problem hiding this comment.
IIRC this is handled by Jetty and I think Jetty supports other headers also
Member
Author
There was a problem hiding this comment.
Ok .. do you think we need to change anything on the docs here though? I think its fine the way it is.
Also @wendigo ?
Member
There was a problem hiding this comment.
@mosabua I would say the X-Forwarded headers maybe link to this: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For#see_also
dain
reviewed
Jun 1, 2024
dain
approved these changes
Jun 7, 2024
Member
dain
left a comment
dain
left a comment
There was a problem hiding this comment.
One comment but otherwise looks good
Member
There was a problem hiding this comment.
@mosabua I would say the X-Forwarded headers maybe link to this: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For#see_also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally just wanted to add docs for
http-server.process-forwardedbut found that the http-server.* properties are either not found at all or sprinkled across docs. This PR adds a new properties reference page that either documents the properties or links to relevant info.As a result I had to also clean up some related duplication.. but it all belongs together really.
Additional context and related issues
See for example chat in https://trinodb.slack.com/archives/CG9K9MX1V/p1715826092248509
I will also create a PR related Trino Gateway docs PR.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.