Skip to content

Reduce optimizer.max-reordered-joins default to 8 #21360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Reduce optimizer.max-reordered-joins default to 8 #21360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-main/src/main/java/io/trino/sql/planner/OptimizerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class OptimizerConfig
private double joinMultiClauseIndependenceFactor = 0.25;

private JoinReorderingStrategy joinReorderingStrategy = JoinReorderingStrategy.AUTOMATIC;
private int maxReorderedJoins = 9;
private int maxReorderedJoins = 8;
private int maxPrefetchedInformationSchemaPrefixes = 100;

private boolean enableStatsCalculator = true;
Expand Down
2 changes: 1 addition & 1 deletion core/trino-main/src/test/java/io/trino/cost/TestOptimizerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public void testDefaults()
.setJoinDistributionType(JoinDistributionType.AUTOMATIC)
.setJoinMultiClauseIndependenceFactor(0.25)
.setJoinReorderingStrategy(JoinReorderingStrategy.AUTOMATIC)
.setMaxReorderedJoins(9)
.setMaxReorderedJoins(8)
.setMaxPrefetchedInformationSchemaPrefixes(100)
.setColocatedJoinsEnabled(true)
.setSpatialJoinsEnabled(true)
Expand Down
2 changes: 1 addition & 1 deletion docs/src/main/sphinx/admin/properties-optimizer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ for any reason a cost could not be computed, the `ELIMINATE_CROSS_JOINS` strateg
## `optimizer.max-reordered-joins`

- **Type:** {ref}`prop-type-integer`
- **Default value:** `9`
- **Default value:** `8`

When optimizer.join-reordering-strategy is set to cost-based, this property determines
the maximum number of joins that can be reordered at once.
Expand Down