Remove Boolean, Long, Decimal and Double literals in IR #21096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests:hive
iceberg
martint
force-pushed
the
ir-improvements
branch
from
5c19828 to
b3b4289
Compare
dain
approved these changes
Mar 15, 2024
core/trino-main/src/main/java/io/trino/sql/ir/GenericLiteral.java
Outdated
Show resolved
Hide resolved
martint
force-pushed
the
ir-improvements
branch
2 times, most recently
from
503ceef to
0dadbda
Compare
Replace them with GenericLiteral. The values are stored as native carrier type instead of String inside the object.
martint
force-pushed
the
ir-improvements
branch
from
0dadbda to
32c8af0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.