Add cause of failures in ThriftHiveMetastore#19655
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Nov 13, 2023
Merged
Conversation
Member
Please expand rationale. Maybe example of the situation where current error reporting is insufficient and this change helps. |
findinpath
reviewed
Nov 7, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/SchemaAlreadyExistsException.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Nov 7, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/TableAlreadyExistsException.java
Outdated
Show resolved
Hide resolved
98d0acc to
a9506ba
Compare
Contributor
|
Failure in It is going to be likely fixed through #19343 |
findinpath
approved these changes
Nov 10, 2023
ebyhr
reviewed
Nov 12, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/SchemaAlreadyExistsException.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/TableAlreadyExistsException.java
Outdated
Show resolved
Hide resolved
This will be beneficial in case of detecting retry issues
a9506ba to
490cab8
Compare
ebyhr
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be beneficial in case of detecting retry issues.
Currently in case of failure after retry (e.g createTable, dropTable) we have no information that it was consecutive attempt. After this change exceptions from previous attempts will be visible in stack trace.
Example in case 2 attemps:
ClientExceptionNoSuchObjectExceptionBefore:
After:
'''
Description
Additional context and related issues
Release notes
(x ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: