From e17a7d18b5a9f08b2c65dad80170abd547cdca85 Mon Sep 17 00:00:00 2001 From: Martin Traverso Date: Thu, 12 Oct 2023 11:06:27 -0700 Subject: [PATCH] Replace @Parameters annotation Left-over from the migration to JUnit. It's not a valid annotation for JUnit. --- .../iceberg/TestIcebergAbfsConnectorSmokeTest.java | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAbfsConnectorSmokeTest.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAbfsConnectorSmokeTest.java index 26875693c34b..f4146e3adb56 100644 --- a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAbfsConnectorSmokeTest.java +++ b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAbfsConnectorSmokeTest.java @@ -21,7 +21,6 @@ import io.trino.plugin.hive.metastore.thrift.BridgingHiveMetastore; import io.trino.testing.QueryRunner; import org.junit.jupiter.api.Test; -import org.testng.annotations.Parameters; import java.nio.file.Path; import java.nio.file.attribute.FileAttribute; @@ -51,16 +50,12 @@ public class TestIcebergAbfsConnectorSmokeTest private HiveHadoop hiveHadoop; - @Parameters({ - "hive.hadoop2.azure-abfs-container", - "hive.hadoop2.azure-abfs-account", - "hive.hadoop2.azure-abfs-access-key"}) - public TestIcebergAbfsConnectorSmokeTest(String container, String account, String accessKey) + public TestIcebergAbfsConnectorSmokeTest() { super(ORC); - this.container = requireNonNull(container, "container is null"); - this.account = requireNonNull(account, "account is null"); - this.accessKey = requireNonNull(accessKey, "accessKey is null"); + this.container = requireNonNull(System.getProperty("hive.hadoop2.azure-abfs-container"), "container is null"); + this.account = requireNonNull(System.getProperty("hive.hadoop2.azure-abfs-account"), "account is null"); + this.accessKey = requireNonNull(System.getProperty("hive.hadoop2.azure-abfs-access-key"), "accessKey is null"); this.schemaName = "tpch_" + format.name().toLowerCase(ENGLISH); this.bucketName = "test-iceberg-smoke-test-" + randomNameSuffix(); }