diff --git a/docs/src/main/sphinx/connector/hudi.md b/docs/src/main/sphinx/connector/hudi.md index 2c257abd9627..1236a4b21375 100644 --- a/docs/src/main/sphinx/connector/hudi.md +++ b/docs/src/main/sphinx/connector/hudi.md @@ -44,9 +44,6 @@ Additionally, following configuration properties can be set depending on the use * - Property name - Description - Default - * - ``hudi.metadata-enabled`` - - Fetch the list of file names and sizes from metadata rather than storage. - - ``false`` * - ``hudi.columns-to-hide`` - List of column names that are hidden from the query output. It can be used to hide Hudi meta fields. By default, no fields are hidden. diff --git a/plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiConfig.java b/plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiConfig.java index 0fb2653c28c2..c7fd2f84e4bb 100644 --- a/plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiConfig.java +++ b/plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiConfig.java @@ -34,13 +34,13 @@ @DefunctConfig({ "hudi.min-partition-batch-size", "hudi.max-partition-batch-size", + "hudi.metadata-enabled", }) public class HudiConfig { private static final Splitter COMMA_SPLITTER = Splitter.on(",").omitEmptyStrings().trimResults(); private List columnsToHide = ImmutableList.of(); - private boolean metadataEnabled; private boolean shouldUseParquetColumnNames = true; private boolean sizeBasedSplitWeightsEnabled = true; private DataSize standardSplitWeightSize = DataSize.of(128, MEGABYTE); @@ -67,19 +67,6 @@ public HudiConfig setColumnsToHide(String columnsToHide) return this; } - @Config("hudi.metadata-enabled") - @ConfigDescription("Fetch the list of file names and sizes from metadata rather than storage.") - public HudiConfig setMetadataEnabled(boolean metadataEnabled) - { - this.metadataEnabled = metadataEnabled; - return this; - } - - public boolean isMetadataEnabled() - { - return this.metadataEnabled; - } - @Config("hudi.parquet.use-column-names") @ConfigDescription("Access Parquet columns using names from the file. If disabled, then columns are accessed using index." + "Only applicable to Parquet file format.") diff --git a/plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiSessionProperties.java b/plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiSessionProperties.java index 7d76398f6fe7..f8be4dfa5843 100644 --- a/plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiSessionProperties.java +++ b/plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiSessionProperties.java @@ -39,7 +39,6 @@ public class HudiSessionProperties implements SessionPropertiesProvider { private static final String COLUMNS_TO_HIDE = "columns_to_hide"; - private static final String METADATA_ENABLED = "metadata_enabled"; private static final String USE_PARQUET_COLUMN_NAMES = "use_parquet_column_names"; private static final String SIZE_BASED_SPLIT_WEIGHTS_ENABLED = "size_based_split_weights_enabled"; private static final String STANDARD_SPLIT_WEIGHT_SIZE = "standard_split_weight_size"; @@ -65,11 +64,6 @@ public HudiSessionProperties(HudiConfig hudiConfig) .map(name -> ((String) name).toLowerCase(ENGLISH)) .collect(toImmutableList()), value -> value), - booleanProperty( - METADATA_ENABLED, - "For Hudi tables prefer to fetch the list of files from its metadata", - hudiConfig.isMetadataEnabled(), - false), booleanProperty( USE_PARQUET_COLUMN_NAMES, "Access parquet columns using names from the file. If disabled, then columns are accessed using index.", @@ -124,11 +118,6 @@ public static List getColumnsToHide(ConnectorSession session) return (List) session.getProperty(COLUMNS_TO_HIDE, List.class); } - public static boolean isHudiMetadataEnabled(ConnectorSession session) - { - return session.getProperty(METADATA_ENABLED, Boolean.class); - } - public static boolean shouldUseParquetColumnNames(ConnectorSession session) { return session.getProperty(USE_PARQUET_COLUMN_NAMES, Boolean.class); diff --git a/plugin/trino-hudi/src/test/java/io/trino/plugin/hudi/TestHudiConfig.java b/plugin/trino-hudi/src/test/java/io/trino/plugin/hudi/TestHudiConfig.java index dbe2427e30ff..3c3807bd5ad8 100644 --- a/plugin/trino-hudi/src/test/java/io/trino/plugin/hudi/TestHudiConfig.java +++ b/plugin/trino-hudi/src/test/java/io/trino/plugin/hudi/TestHudiConfig.java @@ -31,7 +31,6 @@ public void testDefaults() { assertRecordedDefaults(recordDefaults(HudiConfig.class) .setColumnsToHide(null) - .setMetadataEnabled(false) .setUseParquetColumnNames(true) .setSizeBasedSplitWeightsEnabled(true) .setStandardSplitWeightSize(DataSize.of(128, MEGABYTE)) @@ -48,7 +47,6 @@ public void testExplicitPropertyMappings() { Map properties = ImmutableMap.builder() .put("hudi.columns-to-hide", "_hoodie_record_key") - .put("hudi.metadata-enabled", "true") .put("hudi.parquet.use-column-names", "false") .put("hudi.size-based-split-weights-enabled", "false") .put("hudi.standard-split-weight-size", "64MB") @@ -62,7 +60,6 @@ public void testExplicitPropertyMappings() HudiConfig expected = new HudiConfig() .setColumnsToHide("_hoodie_record_key") - .setMetadataEnabled(true) .setUseParquetColumnNames(false) .setSizeBasedSplitWeightsEnabled(false) .setStandardSplitWeightSize(DataSize.of(64, MEGABYTE)) diff --git a/plugin/trino-hudi/src/test/java/io/trino/plugin/hudi/TestHudiConnectorMetadataTest.java b/plugin/trino-hudi/src/test/java/io/trino/plugin/hudi/TestHudiConnectorMetadataTest.java deleted file mode 100644 index e5ae56bae2bb..000000000000 --- a/plugin/trino-hudi/src/test/java/io/trino/plugin/hudi/TestHudiConnectorMetadataTest.java +++ /dev/null @@ -1,31 +0,0 @@ -/* - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package io.trino.plugin.hudi; - -import com.google.common.collect.ImmutableMap; -import io.trino.plugin.hudi.testing.ResourceHudiTablesInitializer; -import io.trino.testing.QueryRunner; - -import static io.trino.plugin.hudi.HudiQueryRunner.createHudiQueryRunner; - -public class TestHudiConnectorMetadataTest - extends TestHudiSmokeTest -{ - @Override - protected QueryRunner createQueryRunner() - throws Exception - { - return createHudiQueryRunner(ImmutableMap.of(), ImmutableMap.of("hudi.metadata-enabled", "true"), new ResourceHudiTablesInitializer()); - } -}