Skip to content

Conversation

@colebow
Copy link
Member

@colebow colebow commented Jun 22, 2023

Description

We haven't maintained this section of the Alluxio docs in Trino, and it's out of date and inaccurate. Alluxio has their own documentation for running their platform with Trino, and it's been kept up to date much more effectively, so it's simpler, easier, and more accurate to direct users to that page to ensure that they're getting up-to-date information.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Jun 22, 2023
@colebow colebow requested a review from mosabua June 22, 2023 19:23
@colebow colebow force-pushed the colebow/alluxio-docs branch from 0e031b2 to f54812c Compare June 22, 2023 19:26
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Remind me to merge after the release is out.

@github-actions github-actions bot added the docs label Jun 22, 2023
Copy link
Member

@beinan beinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@colebow colebow requested a review from ebyhr June 27, 2023 16:07
@mosabua
Copy link
Member

mosabua commented Jun 28, 2023

Related to #16375

@ebyhr
Copy link
Member

ebyhr commented Jun 29, 2023

Related to #16375

How it's related to? The PR doesn't remove hive.metastore=alluxio-deprecated as far as I confirmed.

@mosabua
Copy link
Member

mosabua commented Jun 29, 2023

Related to #16375

How it's related to? The PR doesn't remove hive.metastore=alluxio-deprecated as far as I confirmed.

It is related in the sense that the current doc update in this PR adjusts to the fact that the documentation for using Alluxio on the Trino site it outdated and wrong. The correct docs are on the Alluxio site and linked with this PR.

At the same time the linked PR will change how this works again and the documentation for the new setup will probably also live on the Alluxio site .. on the same URL.

And yes.. the removal of the metastore stuff is NOT in that linked PR. @beinan is currently confirming and will sent a separate PR for that

@mosabua
Copy link
Member

mosabua commented Jul 7, 2023

@beinan do you have an update? Can you confirm that your current setup does NOT use/need hive.metastore=alluxio-deprecated

@mosabua
Copy link
Member

mosabua commented Jul 7, 2023

I clarified with @beinan .. the current Alluxio usage does NOT need the metastore configuration. We can therefore merge this PR. The removal of the code of this can be done separately. Beinan will work towards sending a PR for that as well.

@colebow colebow force-pushed the colebow/alluxio-docs branch from f54812c to 37b369f Compare July 10, 2023 18:43
@mosabua
Copy link
Member

mosabua commented Jul 10, 2023

Verified local build. Merging.

@mosabua mosabua merged commit ed9ac16 into trinodb:master Jul 10, 2023
@github-actions github-actions bot added this to the 422 milestone Jul 10, 2023
@martint
Copy link
Member

martint commented Jul 11, 2023

This broke the build:

Warning, treated as error:
/docs/src/main/sphinx/release/release-332.md:63:undefined label: alluxio-catalog-service

martint added a commit to martint/trino that referenced this pull request Jul 11, 2023
martint added a commit that referenced this pull request Jul 11, 2023
This fixes a build failure introduced by #18022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants