Add doc for table_changes function #17252

homar · 2023-04-26T18:03:20Z

Description

Docs changes for #16205

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.

mosabua · 2023-04-27T01:00:08Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

Functions

Table functions

mosabua · 2023-04-27T01:00:22Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

The connector exposes the following table functions:

The connector provides the following table functions:

mosabua · 2023-04-27T01:01:08Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

system.table_changes

table_changes

mosabua · 2023-04-27T01:01:47Z

docs/src/main/sphinx/connector/delta-lake.rst

Wrapping is still weird for this paragraph .. 80 char would be ideal

mosabua · 2023-04-27T01:03:22Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

In addition to columns present in the table this function

In addition to columns present in the table

mosabua · 2023-04-27T01:05:03Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

Type ``VARCHAR``, gives the type of change that occurred,

Gives the type of change that occurred as represented as ``VARCHAR`` value.

mosabua · 2023-04-27T01:08:02Z

docs/src/main/sphinx/connector/delta-lake.rst

add schema_name and table_name as required parameters

mosabua · 2023-04-27T01:09:23Z

docs/src/main/sphinx/connector/delta-lake.rst

I think we should at least move values down into a separate line

mosabua · 2023-04-27T01:09:40Z

docs/src/main/sphinx/connector/delta-lake.rst

three lines

sorry i don't get this comment :|

UPDATE pages SET domain = 'domain4' WHERE views = 2;

mosabua · 2023-04-27T01:10:11Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

In the output it can be easily seen what changes happen in which version.

The output shows what changes happen in which version.

mosabua · 2023-04-27T01:11:52Z

docs/src/main/sphinx/connector/delta-lake.rst

From 833 to 861 .. this is all the same as above right. .. if so .. just omit it all

mosabua · 2023-05-01T16:07:42Z

docs/src/main/sphinx/connector/delta-lake.rst

mosabua · 2023-05-01T16:08:20Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

Gives the type of change that occurred as represented as ``VARCHAR`` value.

Gives the type of change that occurred.

and wrap

mosabua · 2023-05-01T16:08:35Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

Shows the table version for which the change occurred as ``BIGINT`` value.

Shows the table version for which the change occurred.

mosabua · 2023-05-01T16:09:02Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

``TIMESTAMP(3) WITH TIME ZONE`` data type value.

mosabua · 2023-05-01T16:09:13Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

Represents the timestamp for the commit in which the specified change happened as

Represents the timestamp for the commit in which the specified change happened.

mosabua · 2023-05-01T16:13:24Z

docs/src/main/sphinx/connector/delta-lake.rst

I think we need to add the schema to the queries above to be clear

Or add a "use" command first

mosabua · 2023-05-01T16:14:38Z

docs/src/main/sphinx/connector/delta-lake.rst

We can omit that .. its implied since we are still talking about the same example

mosabua · 2023-05-01T16:14:58Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

The preceding sequence of SQL statements returns the following result:

The preceding SQL statement returns the following result:

mosabua · 2023-05-01T16:16:10Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

Here we can see changes that occurred at version 1 - three inserts - they were

You can see changes that occurred at version 1 as- three inserts. They are

mosabua · 2023-05-01T16:16:26Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

not visible in the previous code snippet when since_version value was set to 1.

not visible in the previous statement when since_version value was set to 1.

mosabua · 2023-05-01T16:28:07Z

I simplified a bit..

mosabua · 2023-05-11T17:11:13Z

Let me know when you have the code PR ready and this updates so I can review for latest status. Also currently this PR conflicts..

mosabua · 2023-05-12T16:45:31Z

@findepi merged the code PR. @homar can you please make sure you resolve the conflicts and address any comments as soon as possible so we can make sure we get this PR merged before the release next week. Also adapt the docs to whatever changed in the code before merge ..

homar · 2023-05-14T09:49:20Z

@findepi merged the code PR. @homar can you please make sure you resolve the conflicts and address any comments as soon as possible so we can make sure we get this PR merged before the release next week. Also adapt the docs to whatever changed in the code before merge ..

Yeah sorry, I was in warsaw office for 2 days and I didn't have time to update this one. I have updated it only now

colebow

One nit, but LGTM.

colebow · 2023-05-18T17:31:39Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

In addition to columns present in the table the function returns the following

In addition to returning the columns present in the table, the function

returns the following

Please apply this suggestion @homar

mosabua

Needs some reordering

docs/src/main/sphinx/connector/delta-lake.rst

mosabua · 2023-05-18T21:57:30Z

docs/src/main/sphinx/connector/delta-lake.rst

Expand this to a sentence.

mosabua · 2023-05-18T21:58:23Z

docs/src/main/sphinx/connector/delta-lake.rst

mosabua · 2023-05-18T21:58:41Z

docs/src/main/sphinx/connector/delta-lake.rst

Suggested change

not visible in the previous statement when since_version value was set to 1.

not visible in the previous statement when ``since_version`` value was set to 1.

mosabua · 2023-05-24T03:24:14Z

@homar .. are you updating this PR so we can review again and maybe merge soon?

mosabua

Looks good now. Let's ship it.

mosabua

Looks good now. Let's ship it.

cla-bot bot added the cla-signed label Apr 26, 2023

homar mentioned this pull request Apr 26, 2023

Implement table changes function for delta lake #16205

Merged

homar requested a review from mosabua April 26, 2023 18:29

github-actions bot added the docs label Apr 26, 2023

mosabua reviewed Apr 27, 2023

View reviewed changes

docs/src/main/sphinx/connector/delta-lake.rst Outdated

Copy link

Member

mosabua Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Functions

Table functions

homar reacted with thumbs up emoji

mosabua requested changes Apr 27, 2023

View reviewed changes

homar force-pushed the homar/table_changes_docs branch from 3f6001f to 0ca3e00 Compare April 27, 2023 08:37

mosabua requested changes May 1, 2023

View reviewed changes

homar force-pushed the homar/table_changes_docs branch from 0ca3e00 to 32c4b40 Compare May 14, 2023 09:48

homar requested a review from mosabua May 17, 2023 16:39

colebow approved these changes May 18, 2023

View reviewed changes

mosabua requested changes May 18, 2023

View reviewed changes

Add doc for table_changes function

f949996

homar force-pushed the homar/table_changes_docs branch from 32c4b40 to f949996 Compare May 24, 2023 09:28

mosabua approved these changes May 25, 2023

View reviewed changes

mosabua merged commit 144840d into trinodb:master May 25, 2023

github-actions bot added this to the 419 milestone May 25, 2023

colebow mentioned this pull request Jun 2, 2023

Add Trino 419 release notes #17626

Merged

	The connector exposes the following table functions:
	The connector provides the following table functions:

	In addition to columns present in the table this function
	In addition to columns present in the table

	Type ``VARCHAR``, gives the type of change that occurred,
	Gives the type of change that occurred as represented as ``VARCHAR`` value.

	In the output it can be easily seen what changes happen in which version.
	The output shows what changes happen in which version.

	Gives the type of change that occurred as represented as ``VARCHAR`` value.
	Gives the type of change that occurred.

	Shows the table version for which the change occurred as ``BIGINT`` value.
	Shows the table version for which the change occurred.

	Represents the timestamp for the commit in which the specified change happened as
	Represents the timestamp for the commit in which the specified change happened.

	The preceding sequence of SQL statements returns the following result:
	The preceding SQL statement returns the following result:

	Here we can see changes that occurred at version 1 - three inserts - they were
	You can see changes that occurred at version 1 as- three inserts. They are

	not visible in the previous code snippet when since_version value was set to 1.
	not visible in the previous statement when since_version value was set to 1.

	In addition to columns present in the table the function returns the following
	In addition to returning the columns present in the table, the function
	returns the following

Add doc for table_changes function #17252

Add doc for table_changes function #17252

Uh oh!

Conversation

homar commented Apr 26, 2023 • edited by mosabua Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Additional context and related issues

Release notes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mosabua commented May 1, 2023

Uh oh!

mosabua commented May 11, 2023

Uh oh!

mosabua commented May 12, 2023

Uh oh!

homar commented May 14, 2023

Uh oh!

colebow left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mosabua left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

homar commented Apr 26, 2023 •

edited by mosabua

Loading