diff --git a/core/trino-spi/src/main/java/io/trino/spi/metrics/Metrics.java b/core/trino-spi/src/main/java/io/trino/spi/metrics/Metrics.java index f54ac8844eb5..4f21eb5bdf8a 100644 --- a/core/trino-spi/src/main/java/io/trino/spi/metrics/Metrics.java +++ b/core/trino-spi/src/main/java/io/trino/spi/metrics/Metrics.java @@ -93,12 +93,6 @@ private Accumulator() { } - public Accumulator add(List metricsList) - { - metricsList.forEach(this::add); - return this; - } - public Accumulator add(Metrics metrics) { metrics.getMetrics().forEach((key, value) -> diff --git a/lib/trino-plugin-toolkit/src/test/java/io/trino/plugin/base/metrics/TestMetrics.java b/lib/trino-plugin-toolkit/src/test/java/io/trino/plugin/base/metrics/TestMetrics.java index be0d895d6f91..0f771e84fc33 100644 --- a/lib/trino-plugin-toolkit/src/test/java/io/trino/plugin/base/metrics/TestMetrics.java +++ b/lib/trino-plugin-toolkit/src/test/java/io/trino/plugin/base/metrics/TestMetrics.java @@ -116,6 +116,10 @@ public void testReduceSingleMetrics() { Metrics metrics = new Metrics(ImmutableMap.of("a", new LongCount(0))); assertThat(accumulator().add(metrics).get()).isEqualTo(metrics); + + Metrics metrics1 = new Metrics(ImmutableMap.of("a", new LongCount(1))); + Metrics metrics2 = new Metrics(ImmutableMap.of("a", new LongCount(2))); + assertThat(accumulator().add(metrics1).add(metrics2).get()).isEqualTo(new Metrics(ImmutableMap.of("a", new LongCount(3)))); } private static Metrics merge(Metrics... metrics)