diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java index e38f035a0478..584d2d42b645 100644 --- a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java +++ b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java @@ -472,10 +472,10 @@ public void testFileSortingWithLargerTable() try (TestTable table = new TestTable( getQueryRunner()::execute, "test_sorted_lineitem_table", - "WITH (sorted_by = ARRAY['comment'], format = '" + format.name() + "') AS SELECT * FROM lineitem WITH NO DATA")) { + "WITH (sorted_by = ARRAY['comment'], format = '" + format.name() + "') AS TABLE tpch.tiny.lineitem WITH NO DATA")) { assertUpdate( withSmallRowGroups, - "INSERT INTO " + table.getName() + " SELECT * FROM lineitem", + "INSERT INTO " + table.getName() + " TABLE tpch.tiny.lineitem", "VALUES 60175"); for (Object filePath : computeActual("SELECT file_path from \"" + table.getName() + "$files\"").getOnlyColumnAsSet()) { assertTrue(isFileSorted((String) filePath, "comment")); diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java index 706b7bda16e8..a2e8666c2e94 100644 --- a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java +++ b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java @@ -42,7 +42,6 @@ import io.trino.testing.QueryRunner; import io.trino.testing.TestingConnectorBehavior; import io.trino.testing.sql.TestTable; -import io.trino.tpch.TpchTable; import org.apache.avro.Schema; import org.apache.avro.file.DataFileReader; import org.apache.avro.file.DataFileWriter; @@ -117,7 +116,6 @@ import static io.trino.testing.TestingNames.randomNameSuffix; import static io.trino.testing.TestingSession.testSessionBuilder; import static io.trino.testing.assertions.Assert.assertEventually; -import static io.trino.tpch.TpchTable.LINE_ITEM; import static io.trino.transaction.TransactionBuilder.transaction; import static java.lang.String.format; import static java.lang.String.join; @@ -167,10 +165,7 @@ protected IcebergQueryRunner.Builder createQueryRunnerBuilder() // Allows testing the sorting writer flushing to the file system with smaller tables .put("iceberg.writer-sort-buffer-size", "1MB") .buildOrThrow()) - .setInitialTables(ImmutableList.>builder() - .addAll(REQUIRED_TPCH_TABLES) - .add(LINE_ITEM) - .build()); + .setInitialTables(REQUIRED_TPCH_TABLES); } @SuppressWarnings("DuplicateBranchesInSwitch") @@ -1320,9 +1315,9 @@ public void testUpdateWithSortOrder() try (TestTable table = new TestTable( getQueryRunner()::execute, "test_sorted_update", - "WITH (sorted_by = ARRAY['comment']) AS SELECT * FROM lineitem WITH NO DATA")) { + "WITH (sorted_by = ARRAY['comment']) AS TABLE tpch.tiny.lineitem WITH NO DATA")) { assertUpdate( - "INSERT INTO " + table.getName() + " SELECT * FROM lineitem", + "INSERT INTO " + table.getName() + " TABLE tpch.tiny.lineitem", "VALUES 60175"); assertUpdate(withSmallRowGroups, "UPDATE " + table.getName() + " SET comment = substring(comment, 2)", 60175); assertQuery( diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMinioConnectorSmokeTest.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMinioConnectorSmokeTest.java index 2f10e9f6dd50..450083e11e0e 100644 --- a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMinioConnectorSmokeTest.java +++ b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMinioConnectorSmokeTest.java @@ -13,7 +13,6 @@ */ package io.trino.plugin.iceberg; -import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; import io.minio.messages.Event; @@ -34,7 +33,6 @@ import io.trino.plugin.hive.s3.TrinoS3ConfigurationInitializer; import io.trino.testing.QueryRunner; import io.trino.testing.minio.MinioClient; -import io.trino.tpch.TpchTable; import org.apache.iceberg.FileFormat; import org.intellij.lang.annotations.Language; import org.testng.annotations.Test; @@ -50,7 +48,6 @@ import static io.trino.testing.TestingNames.randomNameSuffix; import static io.trino.testing.containers.Minio.MINIO_ACCESS_KEY; import static io.trino.testing.containers.Minio.MINIO_SECRET_KEY; -import static io.trino.tpch.TpchTable.LINE_ITEM; import static java.lang.String.format; import static java.util.Locale.ENGLISH; import static org.assertj.core.api.Assertions.assertThat; @@ -104,10 +101,7 @@ protected QueryRunner createQueryRunner() .setSchemaInitializer( SchemaInitializer.builder() .withSchemaName(schemaName) - .withClonedTpchTables(ImmutableList.>builder() - .addAll(REQUIRED_TPCH_TABLES) - .add(LINE_ITEM) - .build()) + .withClonedTpchTables(REQUIRED_TPCH_TABLES) .withSchemaProperties(Map.of("location", "'s3://" + bucketName + "/" + schemaName + "'")) .build()) .build(); diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAbfsConnectorSmokeTest.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAbfsConnectorSmokeTest.java index c9065269aa73..037613a3cb36 100644 --- a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAbfsConnectorSmokeTest.java +++ b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAbfsConnectorSmokeTest.java @@ -13,7 +13,6 @@ */ package io.trino.plugin.iceberg; -import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; import com.google.common.io.Resources; @@ -32,7 +31,6 @@ import io.trino.plugin.hive.metastore.HiveMetastore; import io.trino.plugin.hive.metastore.thrift.BridgingHiveMetastore; import io.trino.testing.QueryRunner; -import io.trino.tpch.TpchTable; import org.testng.annotations.Parameters; import org.testng.annotations.Test; @@ -46,7 +44,6 @@ import static io.trino.plugin.hive.TestingThriftHiveMetastoreBuilder.testingThriftHiveMetastoreBuilder; import static io.trino.plugin.iceberg.IcebergTestUtils.checkOrcFileSorting; import static io.trino.testing.TestingNames.randomNameSuffix; -import static io.trino.tpch.TpchTable.LINE_ITEM; import static java.lang.String.format; import static java.nio.charset.StandardCharsets.UTF_8; import static java.util.Locale.ENGLISH; @@ -122,10 +119,7 @@ protected QueryRunner createQueryRunner() .setSchemaInitializer( SchemaInitializer.builder() .withSchemaName(schemaName) - .withClonedTpchTables(ImmutableList.>builder() - .addAll(REQUIRED_TPCH_TABLES) - .add(LINE_ITEM) - .build()) + .withClonedTpchTables(REQUIRED_TPCH_TABLES) .withSchemaProperties(Map.of("location", "'" + formatAbfsUrl(container, account, bucketName) + schemaName + "'")) .build()) .build(); diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergConnectorSmokeTest.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergConnectorSmokeTest.java index 05f5b546ca21..61314d9027e6 100644 --- a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergConnectorSmokeTest.java +++ b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergConnectorSmokeTest.java @@ -13,11 +13,9 @@ */ package io.trino.plugin.iceberg; -import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import io.trino.plugin.hive.metastore.HiveMetastore; import io.trino.testing.QueryRunner; -import io.trino.tpch.TpchTable; import org.testng.annotations.AfterClass; import java.io.File; @@ -30,7 +28,6 @@ import static com.google.common.io.RecursiveDeleteOption.ALLOW_INSECURE; import static io.trino.plugin.hive.metastore.file.FileHiveMetastore.createTestingFileHiveMetastore; import static io.trino.plugin.iceberg.IcebergTestUtils.checkOrcFileSorting; -import static io.trino.tpch.TpchTable.LINE_ITEM; import static java.lang.String.format; import static org.apache.iceberg.FileFormat.ORC; import static org.assertj.core.api.Assertions.assertThat; @@ -56,10 +53,7 @@ protected QueryRunner createQueryRunner() this.metastoreDir.deleteOnExit(); this.metastore = createTestingFileHiveMetastore(metastoreDir); return IcebergQueryRunner.builder() - .setInitialTables(ImmutableList.>builder() - .addAll(REQUIRED_TPCH_TABLES) - .add(LINE_ITEM) - .build()) + .setInitialTables(REQUIRED_TPCH_TABLES) .setMetastoreDirectory(metastoreDir) .setIcebergProperties(ImmutableMap.of( "iceberg.register-table-procedure.enabled", "true", diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergGcsConnectorSmokeTest.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergGcsConnectorSmokeTest.java index e22dc4643708..b9e904352ca6 100644 --- a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergGcsConnectorSmokeTest.java +++ b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergGcsConnectorSmokeTest.java @@ -13,7 +13,6 @@ */ package io.trino.plugin.iceberg; -import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; import com.google.common.io.Resources; @@ -35,7 +34,6 @@ import io.trino.plugin.hive.metastore.thrift.BridgingHiveMetastore; import io.trino.testing.QueryRunner; import io.trino.testing.TestingConnectorBehavior; -import io.trino.tpch.TpchTable; import org.testng.annotations.AfterClass; import org.testng.annotations.Parameters; import org.testng.annotations.Test; @@ -55,7 +53,6 @@ import static io.trino.plugin.iceberg.IcebergTestUtils.checkOrcFileSorting; import static io.trino.testing.TestingConnectorSession.SESSION; import static io.trino.testing.TestingNames.randomNameSuffix; -import static io.trino.tpch.TpchTable.LINE_ITEM; import static java.lang.String.format; import static java.nio.charset.StandardCharsets.UTF_8; import static java.util.Objects.requireNonNull; @@ -126,10 +123,7 @@ protected QueryRunner createQueryRunner() .buildOrThrow()) .setSchemaInitializer( SchemaInitializer.builder() - .withClonedTpchTables(ImmutableList.>builder() - .addAll(REQUIRED_TPCH_TABLES) - .add(LINE_ITEM) - .build()) + .withClonedTpchTables(REQUIRED_TPCH_TABLES) .withSchemaName(schema) .withSchemaProperties(ImmutableMap.of("location", "'" + schemaPath() + "'")) .build()) diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/file/TestIcebergFileMetastoreTableOperationsInsertFailure.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/file/TestIcebergFileMetastoreTableOperationsInsertFailure.java index b61b6f0f8a62..94a7e93e8365 100644 --- a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/file/TestIcebergFileMetastoreTableOperationsInsertFailure.java +++ b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/file/TestIcebergFileMetastoreTableOperationsInsertFailure.java @@ -32,8 +32,6 @@ import org.testng.annotations.Test; import java.io.File; -import java.io.IOException; -import java.io.UncheckedIOException; import java.nio.file.Files; import java.util.Optional; @@ -55,18 +53,14 @@ public class TestIcebergFileMetastoreTableOperationsInsertFailure @Override protected LocalQueryRunner createQueryRunner() + throws Exception { Session session = testSessionBuilder() .setCatalog(ICEBERG_CATALOG) .setSchema(SCHEMA_NAME) .build(); - try { - baseDir = Files.createTempDirectory(null).toFile(); - } - catch (IOException e) { - throw new UncheckedIOException(e); - } + baseDir = Files.createTempDirectory(null).toFile(); HiveMetastore metastore = new FileHiveMetastore( new NodeVersion("testversion"), diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogConnectorSmokeTest.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogConnectorSmokeTest.java index 2fb484e1fe33..8668c118c1ec 100644 --- a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogConnectorSmokeTest.java +++ b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogConnectorSmokeTest.java @@ -23,7 +23,6 @@ import com.amazonaws.services.s3.model.ListObjectsV2Request; import com.amazonaws.services.s3.model.ListObjectsV2Result; import com.amazonaws.services.s3.model.S3ObjectSummary; -import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; import io.trino.filesystem.TrinoFileSystem; @@ -41,7 +40,6 @@ import io.trino.plugin.iceberg.SchemaInitializer; import io.trino.testing.QueryRunner; import io.trino.testing.sql.TestView; -import io.trino.tpch.TpchTable; import org.apache.iceberg.FileFormat; import org.testng.annotations.AfterClass; import org.testng.annotations.Parameters; @@ -54,7 +52,6 @@ import static io.trino.plugin.iceberg.IcebergTestUtils.checkParquetFileSorting; import static io.trino.testing.TestingConnectorSession.SESSION; import static io.trino.testing.TestingNames.randomNameSuffix; -import static io.trino.tpch.TpchTable.LINE_ITEM; import static java.lang.String.format; import static java.util.Objects.requireNonNull; import static org.assertj.core.api.Assertions.assertThat; @@ -99,10 +96,7 @@ protected QueryRunner createQueryRunner() "iceberg.writer-sort-buffer-size", "1MB")) .setSchemaInitializer( SchemaInitializer.builder() - .withClonedTpchTables(ImmutableList.>builder() - .addAll(REQUIRED_TPCH_TABLES) - .add(LINE_ITEM) - .build()) + .withClonedTpchTables(REQUIRED_TPCH_TABLES) .withSchemaName(schemaName) .build()) .build(); diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/jdbc/TestIcebergJdbcCatalogConnectorSmokeTest.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/jdbc/TestIcebergJdbcCatalogConnectorSmokeTest.java index f401ed09ff94..59d05e3488f6 100644 --- a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/jdbc/TestIcebergJdbcCatalogConnectorSmokeTest.java +++ b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/jdbc/TestIcebergJdbcCatalogConnectorSmokeTest.java @@ -13,7 +13,6 @@ */ package io.trino.plugin.iceberg.catalog.jdbc; -import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import io.trino.hadoop.ConfigurationInstantiator; import io.trino.plugin.iceberg.BaseIcebergConnectorSmokeTest; @@ -21,7 +20,6 @@ import io.trino.plugin.iceberg.IcebergQueryRunner; import io.trino.testing.QueryRunner; import io.trino.testing.TestingConnectorBehavior; -import io.trino.tpch.TpchTable; import org.apache.iceberg.BaseTable; import org.apache.iceberg.catalog.TableIdentifier; import org.apache.iceberg.jdbc.JdbcCatalog; @@ -38,7 +36,6 @@ import static io.trino.plugin.iceberg.IcebergTestUtils.checkOrcFileSorting; import static io.trino.plugin.iceberg.catalog.jdbc.TestingIcebergJdbcServer.PASSWORD; import static io.trino.plugin.iceberg.catalog.jdbc.TestingIcebergJdbcServer.USER; -import static io.trino.tpch.TpchTable.LINE_ITEM; import static java.lang.String.format; import static org.apache.iceberg.CatalogProperties.CATALOG_IMPL; import static org.apache.iceberg.CatalogProperties.URI; @@ -99,10 +96,7 @@ protected QueryRunner createQueryRunner() .put("iceberg.writer-sort-buffer-size", "1MB") .put("iceberg.jdbc-catalog.default-warehouse-dir", warehouseLocation.getAbsolutePath()) .buildOrThrow()) - .setInitialTables(ImmutableList.>builder() - .addAll(REQUIRED_TPCH_TABLES) - .add(LINE_ITEM) - .build()) + .setInitialTables(REQUIRED_TPCH_TABLES) .build(); } diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergRestCatalogConnectorSmokeTest.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergRestCatalogConnectorSmokeTest.java index 766d0228139a..42fbe4cff641 100644 --- a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergRestCatalogConnectorSmokeTest.java +++ b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergRestCatalogConnectorSmokeTest.java @@ -13,7 +13,6 @@ */ package io.trino.plugin.iceberg.catalog.rest; -import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import io.airlift.http.server.testing.TestingHttpServer; import io.trino.plugin.iceberg.BaseIcebergConnectorSmokeTest; @@ -21,7 +20,6 @@ import io.trino.plugin.iceberg.IcebergQueryRunner; import io.trino.testing.QueryRunner; import io.trino.testing.TestingConnectorBehavior; -import io.trino.tpch.TpchTable; import org.apache.iceberg.catalog.Catalog; import org.apache.iceberg.rest.DelegatingRestSessionCatalog; import org.assertj.core.util.Files; @@ -34,7 +32,6 @@ import static com.google.common.io.RecursiveDeleteOption.ALLOW_INSECURE; import static io.trino.plugin.iceberg.IcebergTestUtils.checkOrcFileSorting; import static io.trino.plugin.iceberg.catalog.rest.RestCatalogTestUtils.backendCatalog; -import static io.trino.tpch.TpchTable.LINE_ITEM; import static java.lang.String.format; import static org.assertj.core.api.Assertions.assertThatThrownBy; @@ -87,10 +84,7 @@ protected QueryRunner createQueryRunner() .put("iceberg.register-table-procedure.enabled", "true") .put("iceberg.writer-sort-buffer-size", "1MB") .buildOrThrow()) - .setInitialTables(ImmutableList.>builder() - .addAll(REQUIRED_TPCH_TABLES) - .add(LINE_ITEM) - .build()) + .setInitialTables(REQUIRED_TPCH_TABLES) .build(); }