From e0d5bd4dd59230c7e711bd5c1425fb7e1e9695cb Mon Sep 17 00:00:00 2001 From: James Petty Date: Wed, 8 Mar 2023 14:03:25 -0500 Subject: [PATCH] Avoid extra allocation in OrderByOperator#getOutput() --- .../src/main/java/io/trino/operator/OrderByOperator.java | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/core/trino-main/src/main/java/io/trino/operator/OrderByOperator.java b/core/trino-main/src/main/java/io/trino/operator/OrderByOperator.java index c81cd4e73fda..3f1c79688132 100644 --- a/core/trino-main/src/main/java/io/trino/operator/OrderByOperator.java +++ b/core/trino-main/src/main/java/io/trino/operator/OrderByOperator.java @@ -18,7 +18,6 @@ import com.google.common.util.concurrent.ListenableFuture; import io.trino.memory.context.LocalMemoryContext; import io.trino.spi.Page; -import io.trino.spi.block.Block; import io.trino.spi.connector.SortOrder; import io.trino.spi.type.Type; import io.trino.spiller.Spiller; @@ -286,11 +285,7 @@ public Page getOutput() return null; } Page nextPage = next.get(); - Block[] blocks = new Block[outputChannels.length]; - for (int i = 0; i < outputChannels.length; i++) { - blocks[i] = nextPage.getBlock(outputChannels[i]); - } - return new Page(nextPage.getPositionCount(), blocks); + return nextPage.getColumns(outputChannels); } @Override