diff --git a/core/trino-main/src/main/java/io/trino/sql/planner/EqualityInference.java b/core/trino-main/src/main/java/io/trino/sql/planner/EqualityInference.java index b0d43f2536d3..a75b2319b264 100644 --- a/core/trino-main/src/main/java/io/trino/sql/planner/EqualityInference.java +++ b/core/trino-main/src/main/java/io/trino/sql/planner/EqualityInference.java @@ -53,11 +53,11 @@ public class EqualityInference { // Comparator used to determine Expression preference when determining canonicals private static final Comparator CANONICAL_COMPARATOR = Comparator - // Current cost heuristic: - // 1) Prefer fewer input symbols - // 2) Prefer smaller expression trees - // 3) Sort the expressions alphabetically - creates a stable consistent ordering (extremely useful for unit testing) - // TODO: be more precise in determining the cost of an expression + // Current cost heuristic: + // 1) Prefer fewer input symbols + // 2) Prefer smaller expression trees + // 3) Sort the expressions alphabetically - creates a stable consistent ordering (extremely useful for unit testing) + // TODO: be more precise in determining the cost of an expression .comparingInt((ToIntFunction) (expression -> SymbolsExtractor.extractAll(expression).size())) .thenComparingLong(expression -> SubExpressionExtractor.extract(expression).count()) .thenComparing(Expression::toString); diff --git a/core/trino-main/src/test/java/io/trino/sql/planner/TestLogicalPlanner.java b/core/trino-main/src/test/java/io/trino/sql/planner/TestLogicalPlanner.java index 9fd65915b0a8..654b3016cf62 100644 --- a/core/trino-main/src/test/java/io/trino/sql/planner/TestLogicalPlanner.java +++ b/core/trino-main/src/test/java/io/trino/sql/planner/TestLogicalPlanner.java @@ -823,15 +823,15 @@ public void testCorrelatedJoinWithNullCondition() "SELECT regionkey, n.name FROM region LEFT JOIN LATERAL (SELECT name FROM nation) n ON NULL", CREATED, anyTree( - correlatedJoin( - List.of("r_row_number", "r_regionkey", "r_name", "r_comment"), - "CAST(null AS boolean)", - tableScan("region", Map.of( - "r_row_number", "row_number", - "r_regionkey", "regionkey", - "r_name", "name", - "r_comment", "comment")), - anyTree(tableScan("nation"))))); + correlatedJoin( + List.of("r_row_number", "r_regionkey", "r_name", "r_comment"), + "CAST(null AS boolean)", + tableScan("region", Map.of( + "r_row_number", "row_number", + "r_regionkey", "regionkey", + "r_name", "name", + "r_comment", "comment")), + anyTree(tableScan("nation"))))); assertPlan( "SELECT regionkey, n.name FROM region LEFT JOIN LATERAL (SELECT name FROM nation) n ON NULL", any(