diff --git a/plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java b/plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java index 4a53d0e7b25d..60d8058227ae 100644 --- a/plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java +++ b/plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java @@ -1812,7 +1812,7 @@ public void dropTable(ConnectorSession session, ConnectorTableHandle tableHandle Table table = metastore.getTable(handle.getSchemaName(), handle.getTableName()) .orElseThrow(() -> new TableNotFoundException(handle.getSchemaTableName())); - metastore.dropTable(session, handle.getSchemaName(), handle.getTableName(), table.getTableType().equals(EXTERNAL_TABLE.toString())); + metastore.dropTable(session, handle.getSchemaName(), handle.getTableName(), table.getTableType().equals(MANAGED_TABLE.toString())); } @Override diff --git a/plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/metastore/DeltaLakeMetastore.java b/plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/metastore/DeltaLakeMetastore.java index 25ee7e22c5c3..c259b1eeec8d 100644 --- a/plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/metastore/DeltaLakeMetastore.java +++ b/plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/metastore/DeltaLakeMetastore.java @@ -45,7 +45,7 @@ public interface DeltaLakeMetastore void createTable(ConnectorSession session, Table table, PrincipalPrivileges principalPrivileges); - void dropTable(ConnectorSession session, String databaseName, String tableName, boolean externalTable); + void dropTable(ConnectorSession session, String databaseName, String tableName, boolean deleteData); void renameTable(ConnectorSession session, SchemaTableName from, SchemaTableName to); diff --git a/plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/metastore/HiveMetastoreBackedDeltaLakeMetastore.java b/plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/metastore/HiveMetastoreBackedDeltaLakeMetastore.java index 390b5d1aba2c..73fdcc6a93ad 100644 --- a/plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/metastore/HiveMetastoreBackedDeltaLakeMetastore.java +++ b/plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/metastore/HiveMetastoreBackedDeltaLakeMetastore.java @@ -166,13 +166,13 @@ public void createTable(ConnectorSession session, Table table, PrincipalPrivileg } @Override - public void dropTable(ConnectorSession session, String databaseName, String tableName, boolean externalTable) + public void dropTable(ConnectorSession session, String databaseName, String tableName, boolean deleteData) { String tableLocation = getTableLocation(new SchemaTableName(databaseName, tableName), session); - delegate.dropTable(databaseName, tableName, true); + delegate.dropTable(databaseName, tableName, deleteData); statisticsAccess.invalidateCache(tableLocation); transactionLogAccess.invalidateCaches(tableLocation); - if (!externalTable) { + if (deleteData) { try { fileSystemFactory.create(session).deleteDirectory(tableLocation); } diff --git a/plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSplitManager.java b/plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSplitManager.java index 6b7f4aee6b07..1c9b80f88bf8 100644 --- a/plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSplitManager.java +++ b/plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSplitManager.java @@ -261,7 +261,7 @@ public void createTable(ConnectorSession session, Table table, PrincipalPrivileg } @Override - public void dropTable(ConnectorSession session, String databaseName, String tableName, boolean externalTable) + public void dropTable(ConnectorSession session, String databaseName, String tableName, boolean deleteData) { throw new UnsupportedOperationException("Unimplemented"); }