From ce639b765b58ea382c20b3a2ff3645ac9da5dca1 Mon Sep 17 00:00:00 2001 From: tangjiangling Date: Fri, 26 Aug 2022 12:55:36 +0800 Subject: [PATCH 1/2] Fix formatting --- .../main/java/io/trino/plugin/clickhouse/ClickHouseClient.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java b/plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java index 7b365bf90855..a9ee82f3564e 100644 --- a/plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java +++ b/plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java @@ -809,7 +809,8 @@ else if (address.length == 16) { private static SliceWriteFunction ipAddressWriteFunction(String bindExpression) { - return new SliceWriteFunction() { + return new SliceWriteFunction() + { @Override public String getBindExpression() { From 3627a85adfe9057514d8dff242c3cb0688271283 Mon Sep 17 00:00:00 2001 From: tangjiangling Date: Fri, 26 Aug 2022 12:56:30 +0800 Subject: [PATCH 2/2] Remove obsolete TODO The TODO was addressed in PR #10672. --- .../main/java/io/trino/plugin/clickhouse/ClickHouseClient.java | 1 - 1 file changed, 1 deletion(-) diff --git a/plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java b/plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java index a9ee82f3564e..d577be7a3d4d 100644 --- a/plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java +++ b/plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java @@ -658,7 +658,6 @@ public WriteMapping toWriteMapping(ConnectorSession session, Type type) return WriteMapping.sliceMapping("String", varbinaryWriteFunction()); } if (type == DATE) { - // TODO (https://github.com/trinodb/trino/issues/10055) Deny unsupported dates to prevent inserting wrong values. 2106-02-07 is max value in version 20.8 return WriteMapping.longMapping("Date", dateWriteFunctionUsingLocalDate()); } if (type == TIMESTAMP_SECONDS) {